Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1339353002: Lazily instantiate Geolocation permission manager maps. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
CC:
blink-reviews, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, dglazkov+blink, timvolodine
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Lazily instantiate Geolocation permission manager maps. Delay creating the bidirectional maps needed to handle Geolocation permission requests until actually used. To avoid instantiating a pair of Persistent<> references when doing so, move the wrapper private object to the Oilpan heap. R=haraken,tkent BUG=340522 Committed: https://crrev.com/261b97814d16304029bf9979cf98fe46d7c76b92 git-svn-id: svn://svn.chromium.org/blink/trunk@202336 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -21 lines) Patch
M Source/web/WebGeolocationPermissionRequestManager.cpp View 2 chunks +30 lines, -17 lines 0 comments Download
M public/web/WebGeolocationPermissionRequestManager.h View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sof
please take a look. No need to populate the main thread's PersistentRegion unnecessarily.
5 years, 3 months ago (2015-09-15 14:29:39 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-09-15 14:54:34 UTC) #3
tkent
lgtm
5 years, 3 months ago (2015-09-15 22:24:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339353002/1
5 years, 3 months ago (2015-09-16 05:09:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339353002/1
5 years, 3 months ago (2015-09-16 06:19:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202336
5 years, 3 months ago (2015-09-16 09:59:40 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:54:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/261b97814d16304029bf9979cf98fe46d7c76b92

Powered by Google App Engine
This is Rietveld 408576698