Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: public/web/WebGeolocationPermissionRequestManager.h

Issue 1339353002: Lazily instantiate Geolocation permission manager maps. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebGeolocationPermissionRequestManager.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebGeolocationPermissionRequestManager.h
diff --git a/public/web/WebGeolocationPermissionRequestManager.h b/public/web/WebGeolocationPermissionRequestManager.h
index b8de3b539603ad40214a4c62b3647a406a3680d3..99ff8b7cc8ab8aa7c1f692d02169a42b3a0c7881 100644
--- a/public/web/WebGeolocationPermissionRequestManager.h
+++ b/public/web/WebGeolocationPermissionRequestManager.h
@@ -27,7 +27,7 @@
#define WebGeolocationPermissionRequestManager_h
#include "../platform/WebNonCopyable.h"
-#include "../platform/WebPrivateOwnPtr.h"
+#include "../platform/WebPrivatePtr.h"
namespace blink {
@@ -42,7 +42,7 @@ class WebGeolocationPermissionRequestManagerPrivate;
// remove the association with the id.
class WebGeolocationPermissionRequestManager : public WebNonCopyable {
public:
- WebGeolocationPermissionRequestManager() { init(); }
+ WebGeolocationPermissionRequestManager() { }
~WebGeolocationPermissionRequestManager() { reset(); }
BLINK_EXPORT int add(const WebGeolocationPermissionRequest&);
@@ -50,10 +50,11 @@ public:
BLINK_EXPORT bool remove(int, WebGeolocationPermissionRequest&);
private:
- BLINK_EXPORT void init();
BLINK_EXPORT void reset();
- WebPrivateOwnPtr<WebGeolocationPermissionRequestManagerPrivate> m_private;
+ WebGeolocationPermissionRequestManagerPrivate* ensureManager();
+
+ WebPrivatePtr<WebGeolocationPermissionRequestManagerPrivate> m_private;
};
}
« no previous file with comments | « Source/web/WebGeolocationPermissionRequestManager.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698