Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1339223002: clang: Disable new warning -Wbitfield-width on the ToT bots. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang: Disable new warning -Wbitfield-width on the ToT bots. The warning fires quite a bit in Chromium. Disable it at least until the pinned clang revision also understands the warning flag, to get the ToT bots back green. BUG=none TBR=hans@chromium.org Committed: https://crrev.com/8f597d66d3808b29d4e73fa4c6751bfbeecaf31c Cr-Commit-Position: refs/heads/master@{#348833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Nico
5 years, 3 months ago (2015-09-15 00:59:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339223002/1
5 years, 3 months ago (2015-09-15 01:15:35 UTC) #3
hans
LGTM If this is mostly firing in protobuf, perhaps we can just fix it?
5 years, 3 months ago (2015-09-15 02:16:04 UTC) #4
Nico
On 2015/09/15 02:16:04, hans wrote: > LGTM > > If this is mostly firing in ...
5 years, 3 months ago (2015-09-15 02:17:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 03:38:53 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8f597d66d3808b29d4e73fa4c6751bfbeecaf31c Cr-Commit-Position: refs/heads/master@{#348833}
5 years, 3 months ago (2015-09-15 03:39:47 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:42:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f597d66d3808b29d4e73fa4c6751bfbeecaf31c
Cr-Commit-Position: refs/heads/master@{#348833}

Powered by Google App Engine
This is Rietveld 408576698