Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: build/common.gypi

Issue 1339223002: clang: Disable new warning -Wbitfield-width on the ToT bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index f7d2141a4ce7e02e8679e27e8d227cab6aad1294..1c1c731b7d9fc6bea81ac0bd8778f73ea1a5b55e 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3108,6 +3108,12 @@
# TODO: Enable on Windows too, http://crbug.com/404525
'variables': { 'clang_warning_flags': ['-Wexit-time-destructors']},
}],
+ ['"<!(python <(DEPTH)/tools/clang/scripts/update.py --print-revision)"!="245965-1"', {
+ # TODO(thakis): Move this to the global clang_warning_flags block once
+ # clang is rolled far enough that the pinned clang understands this flag
+ # TODO(thakis): Consider enabling this?
+ 'variables': { 'clang_warning_flags': ['-Wno-bitfield-width']},
+ }],
['chromium_code==0', {
'variables': {
'clang_warning_flags': [
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698