Add fontconfig to linux DEPS for embedded builds (reland)

Add fontconfig to linux DEPS for embedded builds (reland)

We'll use this in-tree fontconfig when "embedded=1" is set in GYP_DEFINES.

This was reverted pending license checker changes (landed as r127213003).

Relanding with the following changes from the third_party HOWTO:
  - Added OWNERS file
  - Updated .gitignore

BUG=318315
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244318

[spang, 2014-01-10 17:44:47]

Relanding, PTAL

I've added an OWNERS file in particular per
http://www.chromium.org/developers/adding-3rd-party-libraries

[rjkroege, 2014-01-10 18:09:12]

lgtm

[darin (slow to review), 2014-01-10 20:07:13]

https://codereview.chromium.org/133903005/diff/1/third_party/fontconfig/fontc...
File third_party/fontconfig/fontconfig.gyp (right):

https://codereview.chromium.org/133903005/diff/1/third_party/fontconfig/fontc...
third_party/fontconfig/fontconfig.gyp:21: 'src/src/fcarch.h',
what's up with the "src/src" path?

https://codereview.chromium.org/133903005/diff/1/third_party/fontconfig/fontc...
third_party/fontconfig/fontconfig.gyp:53: 'include/src',
what is up with "include/src"? usually a directory named "src" does not appear
inside a directory named "include".

[darin (slow to review), 2014-01-10 20:07:53]

https://codereview.chromium.org/133903005/diff/1/third_party/fontconfig/fontc...
File third_party/fontconfig/fontconfig.gyp (right):

https://codereview.chromium.org/133903005/diff/1/third_party/fontconfig/fontc...
third_party/fontconfig/fontconfig.gyp:33: 'src/src/fcfs.c',
I don't see these source files in this CL. What am I missing? Is there another
CL that needs to land first?

[spang, 2014-01-10 20:08:44]

On 2014/01/10 20:07:53, darin wrote:
>
https://codereview.chromium.org/133903005/diff/1/third_party/fontconfig/fontc...
> File third_party/fontconfig/fontconfig.gyp (right):
> 
>
https://codereview.chromium.org/133903005/diff/1/third_party/fontconfig/fontc...
> third_party/fontconfig/fontconfig.gyp:33: 'src/src/fcfs.c',
> I don't see these source files in this CL. What am I missing? Is there another
> CL that needs to land first?

They are added via DEPS:
https://chromium.googlesource.com/external/fontconfig/+/2.11.0

[spang, 2014-01-10 20:18:56]

https://codereview.chromium.org/133903005/diff/1/third_party/fontconfig/fontc...
File third_party/fontconfig/fontconfig.gyp (right):

https://codereview.chromium.org/133903005/diff/1/third_party/fontconfig/fontc...
third_party/fontconfig/fontconfig.gyp:21: 'src/src/fcarch.h',
On 2014/01/10 20:07:14, darin wrote:
> what's up with the "src/src" path?

fontconfig's upstream repository is checkout out at src/, and contains its own
"src" directory.

I used "src" since that seems conventional, but I agree it's a little odd since
fontconfig has one too.

Would fontconfig/fontconfig be better? Or fontconfig/git?

https://codereview.chromium.org/133903005/diff/1/third_party/fontconfig/fontc...
third_party/fontconfig/fontconfig.gyp:33: 'src/src/fcfs.c',
On 2014/01/10 20:07:53, darin wrote:
> I don't see these source files in this CL. What am I missing? Is there another
> CL that needs to land first?

In this CL via DEPS.

https://codereview.chromium.org/133903005/diff/1/third_party/fontconfig/fontc...
third_party/fontconfig/fontconfig.gyp:53: 'include/src',
On 2014/01/10 20:07:14, darin wrote:
> what is up with "include/src"? usually a directory named "src" does not appear
> inside a directory named "include".

The include directory mirrors the structure of the fontconfig repository, which
has a "src" directory.

It doesn't really matter; I can flatten this into just "include" easily. Done.

[darin (slow to review), 2014-01-10 20:22:00]

Ah, I see. I looked, and there are others that also follow this pattern:

$ grep 'src/src' /tmp/list
./freetype2/src/src
./mesa/src/src
./mesa/src/src/gallium/state_trackers/d3d1x/dxgi/src
./mesa/src/src/gallium/state_trackers/d3d1x/d3d1xshader/src
./mesa/src/src/gallium/state_trackers/d3d1x/d3d1xstutil/src
./mesa/src/src/gtest/src
./sqlite/src/src
./opus/src/src

OK, LGTM


On Fri, Jan 10, 2014 at 12:18 PM, <spang@chromium.org> wrote:

>
> https://codereview.chromium.org/133903005/diff/1/third_
> party/fontconfig/fontconfig.gyp
> File third_party/fontconfig/fontconfig.gyp (right):
>
> https://codereview.chromium.org/133903005/diff/1/third_
> party/fontconfig/fontconfig.gyp#newcode21
> third_party/fontconfig/fontconfig.gyp:21: 'src/src/fcarch.h',
> On 2014/01/10 20:07:14, darin wrote:
>
>> what's up with the "src/src" path?
>>
>
> fontconfig's upstream repository is checkout out at src/, and contains
> its own "src" directory.
>
> I used "src" since that seems conventional, but I agree it's a little
> odd since fontconfig has one too.
>
> Would fontconfig/fontconfig be better? Or fontconfig/git?
>
>
> https://codereview.chromium.org/133903005/diff/1/third_
> party/fontconfig/fontconfig.gyp#newcode33
> third_party/fontconfig/fontconfig.gyp:33: 'src/src/fcfs.c',
> On 2014/01/10 20:07:53, darin wrote:
>
>> I don't see these source files in this CL. What am I missing? Is there
>>
> another
>
>> CL that needs to land first?
>>
>
> In this CL via DEPS.
>
>
> https://codereview.chromium.org/133903005/diff/1/third_
> party/fontconfig/fontconfig.gyp#newcode53
> third_party/fontconfig/fontconfig.gyp:53: 'include/src',
> On 2014/01/10 20:07:14, darin wrote:
>
>> what is up with "include/src"? usually a directory named "src" does
>>
> not appear
>
>> inside a directory named "include".
>>
>
> The include directory mirrors the structure of the fontconfig
> repository, which has a "src" directory.
>
> It doesn't really matter; I can flatten this into just "include" easily.
> Done.
>
> https://codereview.chromium.org/133903005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[spang, 2014-01-10 20:35:05]

https://codereview.chromium.org/133903005/diff/1/third_party/fontconfig/fontc...
File third_party/fontconfig/fontconfig.gyp (right):

https://codereview.chromium.org/133903005/diff/1/third_party/fontconfig/fontc...
third_party/fontconfig/fontconfig.gyp:53: 'include/src',
On 2014/01/10 20:18:56, spang wrote:
> On 2014/01/10 20:07:14, darin wrote:
> > what is up with "include/src"? usually a directory named "src" does not
appear
> > inside a directory named "include".
> 
> The include directory mirrors the structure of the fontconfig repository,
which
> has a "src" directory.
> 
> It doesn't really matter; I can flatten this into just "include" easily. Done.

Actually, it does matter, because of this rather unfortunate #include:

#include "../fc-case/fccase.h"

So we need the include/src for those generated include files from "src".

[commit-bot: I haz the power, 2014-01-10 20:59:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/spang@chromium.org/133903005/140001

[commit-bot: I haz the power, 2014-01-10 23:44:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/spang@chromium.org/133903005/140001

[commit-bot: I haz the power, 2014-01-11 02:54:41]

Change committed as 244318

[Nico, 2014-01-14 03:39:37]

This is missing a LICENSE file, see
http://www.chromium.org/developers/adding-3rd-party-libraries#TOC-Add-a-LICEN...

(there's third_party/OWNERS who're supposed to point out stuff like this)

[spang, 2014-01-14 18:11:13]

On 2014/01/14 03:39:37, Nico wrote:
> This is missing a LICENSE file, see
>
http://www.chromium.org/developers/adding-3rd-party-libraries#TOC-Add-a-LICEN...
> 
> (there's third_party/OWNERS who're supposed to point out stuff like this)

The license file is the COPYING file in the fontconfig repository. That file is
referenced from README.chromium.

Is something gained by copying it to "LICENSE"?

[Nico, 2014-01-14 19:20:05]

My understanding is that
http://www.chromium.org/developers/adding-3rd-party-libraries isn't
advisory, but mandatory. I'm guessing the reasoning for LICENSE is that
different projects put licenses in different places, so we want to have a
single predictable place for everything. (…but I'm not a third_party/OWNER)


On Tue, Jan 14, 2014 at 10:11 AM, <spang@chromium.org> wrote:

> On 2014/01/14 03:39:37, Nico wrote:
>
>> This is missing a LICENSE file, see
>>
>
> http://www.chromium.org/developers/adding-3rd-party-
> libraries#TOC-Add-a-LICENSE-file-and-run-related-checks
>
>  (there's third_party/OWNERS who're supposed to point out stuff like this)
>>
>
> The license file is the COPYING file in the fontconfig repository. That
> file is
> referenced from README.chromium.
>
> Is something gained by copying it to "LICENSE"?
>
> https://codereview.chromium.org/133903005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.