Add fontconfig to linux DEPS for embedded builds (reland)

third_party/fontconfig/fontconfig.gyp

+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+  'targets': [
+    {
+      'target_name': 'fontconfig',
+      'type': '<(component)',
+      'dependencies' : [
+        '../zlib/zlib.gyp:zlib',
+        '../../build/linux/system.gyp:freetype2',
+        '../libxml/libxml.gyp:libxml',
+      ],
+      'defines': [
+          'HAVE_CONFIG_H',
+          'FC_CACHEDIR="/var/cache/fontconfig"',
+          'FONTCONFIG_PATH="/etc/fonts"',
+      ],
+      'sources': [
+        'src/src/fcarch.h',

[darin (slow to review), 2014/01/10 20:07:14]

what's up with the "src/src" path?

[spang, 2014/01/10 20:18:56]

fontconfig's upstream repository is checkout out at src/, and contains its own
"src" directory.

I used "src" since that seems conventional, but I agree it's a little odd since
fontconfig has one too.

Would fontconfig/fontconfig be better? Or fontconfig/git?

+        'src/src/fcatomic.c',
+        'src/src/fcblanks.c',
+        'src/src/fccache.c',
+        'src/src/fccfg.c',
+        'src/src/fccharset.c',
+        'src/src/fccompat.c',
+        'src/src/fcdbg.c',
+        'src/src/fcdefault.c',
+        'src/src/fcdir.c',
+        'src/src/fcformat.c',
+        'src/src/fcfreetype.c',
+        'src/src/fcfs.c',

[darin (slow to review), 2014/01/10 20:07:53]

I don't see these source files in this CL. What am I missing? Is there another
CL that needs to land first?

[spang, 2014/01/10 20:18:56]

In this CL via DEPS.

+        'src/src/fchash.c',
+        'src/src/fcinit.c',
+        'src/src/fclang.c',
+        'src/src/fclist.c',
+        'src/src/fcmatch.c',
+        'src/src/fcmatrix.c',
+        'src/src/fcname.c',
+        'src/src/fcobjs.c',
+        'src/src/fcpat.c',
+        'src/src/fcserialize.c',
+        'src/src/fcstat.c',
+        'src/src/fcstr.c',
+        'src/src/fcxml.c',
+        'src/src/ftglue.h',
+        'src/src/ftglue.c',
+      ],
+      'include_dirs': [
+        'src',
+        'include',
+        'include/src',

[darin (slow to review), 2014/01/10 20:07:14]

what is up with "include/src"? usually a directory named "src" does not appear
inside a directory named "include".

[spang, 2014/01/10 20:18:56]

The include directory mirrors the structure of the fontconfig repository, which
has a "src" directory.

It doesn't really matter; I can flatten this into just "include" easily. Done.

[spang, 2014/01/10 20:35:06]

Actually, it does matter, because of this rather unfortunate #include:

#include "../fc-case/fccase.h"

So we need the include/src for those generated include files from "src".

+      ],
+      'direct_dependent_settings': {
+        'include_dirs': [
+           'src',
+        ],
+      },
+    },
+  ],
+}