Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 13390007: Adding preloaded pin and HSTS for Chrome Dev Tools. (Closed)

Created:
7 years, 8 months ago by palmer
Modified:
7 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Adding preloaded pin and HSTS for Chrome Dev Tools. New host that must be pinned and HTTPS: chrome-devtools-frontend.appspot.com. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191719

Patch Set 1 #

Patch Set 2 : Make the hostname char array large enough #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M net/http/transport_security_state.cc View 1 1 chunk +1 line, -1 line 2 comments Download
M net/http/transport_security_state_static.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/transport_security_state_static.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
palmer
In support of pfeldman's work.
7 years, 8 months ago (2013-04-01 19:24:22 UTC) #1
agl
lgtm
7 years, 8 months ago (2013-04-01 19:27:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/13390007/4001
7 years, 8 months ago (2013-04-02 00:23:17 UTC) #3
commit-bot: I haz the power
Presubmit check for 13390007-4001 failed and returned exit status 1. INFO:root:Found 3 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-02 00:23:23 UTC) #4
palmer
Committed patchset #2 manually as r191719 (presubmit successful).
7 years, 8 months ago (2013-04-02 00:28:46 UTC) #5
cbentzel
https://codereview.chromium.org/13390007/diff/4001/net/http/transport_security_state.cc File net/http/transport_security_state.cc (right): https://codereview.chromium.org/13390007/diff/4001/net/http/transport_security_state.cc#newcode544 net/http/transport_security_state.cc:544: char dns_name[38]; Curious: Do long names trigger compile-time warnings ...
7 years, 7 months ago (2013-04-30 18:28:09 UTC) #6
palmer
7 years, 7 months ago (2013-04-30 18:33:09 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/13390007/diff/4001/net/http/transport_securit...
File net/http/transport_security_state.cc (right):

https://codereview.chromium.org/13390007/diff/4001/net/http/transport_securit...
net/http/transport_security_state.cc:544: char dns_name[38];
> Curious: Do long names trigger compile-time warnings here?

Yep. (Thankfully.)

Powered by Google App Engine
This is Rietveld 408576698