net/http/transport_security_state.cc - Issue 13390007: Adding preloaded pin and HSTS for Chrome Dev Tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/transport_security_state.cc

Issue 13390007: Adding preloaded pin and HSTS for Chrome Dev Tools. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make the hostname char array large enough Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/transport_security_state.cc

diff --git a/net/http/transport_security_state.cc b/net/http/transport_security_state.cc

index 08d1f8ac5c8ee6e449bb80d4738ca3b03cb1e50a..3fb95dde9a30666d7ca20abd212c06be775ed026 100644

--- a/net/http/transport_security_state.cc

+++ b/net/http/transport_security_state.cc

@@ -541,7 +541,7 @@ struct PublicKeyPins {

struct HSTSPreload {

uint8 length;

bool include_subdomains;

- char dns_name[34];

+ char dns_name[38];

cbentzel 2013/04/30 18:28:09 Curious: Do long names trigger compile-time warnin

palmer 2013/04/30 18:33:09 Yep. (Thankfully.)

bool https_required;

PublicKeyPins pins;

SecondLevelDomainName second_level_domain_name;

« no previous file with comments | « no previous file | net/http/transport_security_state_static.h » ('j') | no next file with comments »