Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1338983003: Using GetMoreGeneralElementsKind in more places (Closed)

Created:
5 years, 3 months ago by Camillo Bruni
Modified:
5 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Using GetMoreGeneralElementsKind in more places BUG= Committed: https://crrev.com/28235e94cf4da557ca4a08f9168d8f150067358f Cr-Commit-Position: refs/heads/master@{#30715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M src/builtins.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M src/elements.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338983003/1
5 years, 3 months ago (2015-09-14 06:58:30 UTC) #2
Camillo Bruni
PTAL :) An small addition to https://codereview.chromium.org/1307743011 for some places I missed.
5 years, 3 months ago (2015-09-14 07:18:23 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-14 07:22:37 UTC) #6
mvstanton
lgtm
5 years, 3 months ago (2015-09-14 11:49:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338983003/1
5 years, 3 months ago (2015-09-14 12:15:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 12:17:01 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 12:17:25 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/28235e94cf4da557ca4a08f9168d8f150067358f
Cr-Commit-Position: refs/heads/master@{#30715}

Powered by Google App Engine
This is Rietveld 408576698