Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1307743011: Adding GetMoreGeneralElementsKind in elements-kind.h (Closed)

Created:
5 years, 3 months ago by Camillo Bruni
Modified:
5 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adding GetMoreGeneralElementsKind in elements-kind.h BUG= Committed: https://crrev.com/00b85aabbf4ae245b62177d55f889122d3918abf Cr-Commit-Position: refs/heads/master@{#30614}

Patch Set 1 #

Patch Set 2 : fix? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -27 lines) Patch
M src/builtins.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/elements-kind.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/lookup.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M src/runtime/runtime-literals.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307743011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307743011/20001
5 years, 3 months ago (2015-09-04 15:21:01 UTC) #2
Camillo Bruni
5 years, 3 months ago (2015-09-04 15:46:18 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-04 15:46:29 UTC) #6
Camillo Bruni
PTAL
5 years, 3 months ago (2015-09-07 06:30:54 UTC) #7
mvstanton
Looks good! LGTM.
5 years, 3 months ago (2015-09-07 07:02:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307743011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307743011/20001
5 years, 3 months ago (2015-09-07 08:11:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-07 08:37:25 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 08:37:38 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/00b85aabbf4ae245b62177d55f889122d3918abf
Cr-Commit-Position: refs/heads/master@{#30614}

Powered by Google App Engine
This is Rietveld 408576698