Issue 133893005: [SVG] Handle non-SVGAnimateElement results in calculateAnimatedValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133893005: [SVG] Handle non-SVGAnimateElement results in calculateAnimatedValue() (Closed)

Created:
6 years, 11 months ago by f(malita)

Modified:
6 years, 11 months ago

Reviewers:
pdr.

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, dstockwell, Timothy Loh, krit, f(malita), darktears, pdr, Stephen Chennney, Steve Block, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[SVG] Handle non-SVGAnimateElement results in calculateAnimatedValue() Currently, SVGAnimateElement::calculateAnimatedValue() assumes that the result element is a subtype of SVGAnimateElement, but that is not always the case: SMILTimeContainer::updateAnimations() may pick an SVGAnimateMotionElement for the result. This CL is a workaround - we should take a good look at the SVG animation type hierarchy and figure out why this is needed. BUG=333176 R=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165009

Patch Set 1 #

Patch Set 2 : Patch for landing. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
A	LayoutTests/svg/custom/animate-motion-crash.svg	View		1 chunk	+15 lines, -0 lines	0 comments	Download
A +	LayoutTests/svg/custom/animate-motion-crash-expected.txt	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/svg/SVGAnimateElement.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/animation/SMILTimeContainer.cpp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pdr.

On 2014/01/10 19:27:12, Florin Malita wrote: This is hacky but I think it's actually the ...

6 years, 11 months ago (2014-01-13 20:12:13 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/133893005/80001

6 years, 11 months ago (2014-01-13 20:40:37 UTC) #3

Message was sent while issue was closed.

Change committed as 165009

Expand Messages | Collapse Messages