Source/core/svg/SVGAnimateElement.cpp - Issue 133893005: [SVG] Handle non-SVGAnimateElement results in calculateAnimatedValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGAnimateElement.cpp

Issue 133893005: [SVG] Handle non-SVGAnimateElement results in calculateAnimatedValue() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Patch for landing. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGAnimateElement.cpp

diff --git a/Source/core/svg/SVGAnimateElement.cpp b/Source/core/svg/SVGAnimateElement.cpp

index 198489ce8f806aee2137c4dd308ce969cdf3e4a5..2191456926533a4915f1a397dcc4793b8143580a 100644

--- a/Source/core/svg/SVGAnimateElement.cpp

+++ b/Source/core/svg/SVGAnimateElement.cpp

@@ -99,7 +99,7 @@ void SVGAnimateElement::calculateAnimatedValue(float percentage, unsigned repeat

{

ASSERT(resultElement);

SVGElement* targetElement = this->targetElement();

- if (!targetElement)

+ if (!targetElement || !isSVGAnimateElement(*resultElement))

return;

ASSERT(m_animatedPropertyType == determineAnimatedPropertyType(targetElement));