components/autofill/core/browser/autofill_manager.cc - Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: deletion is working Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_manager.h ('K') | « components/autofill/core/browser/autofill_manager.h ('k') | components/autofill/core/browser/password_autofill_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.cc

diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc

index 22ec8be61893c33aa0bae1a85613c3fa0eeaf2ea..6534c238bd9a4b089d125d3aa7b0aa8d0678ebd6 100644

--- a/components/autofill/core/browser/autofill_manager.cc

+++ b/components/autofill/core/browser/autofill_manager.cc

@@ -612,12 +612,14 @@ void AutofillManager::OnAddPasswordFormMapping(

void AutofillManager::OnShowPasswordSuggestions(

const FormFieldData& field,

+ const PasswordForm& password_form,

vabr (Chromium) 2014/02/05 20:34:20 Please revert all changes in this file and it's *.

const gfx::RectF& bounds,

const std::vector<base::string16>& suggestions,

const std::vector<base::string16>& realms) {

external_delegate_->OnShowPasswordSuggestions(suggestions,

realms,

field,

+ password_form,

bounds);

}