Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: components/autofill/core/browser/autofill_manager.cc

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: deletion is working Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/browser/autofill_manager.h" 5 #include "components/autofill/core/browser/autofill_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <limits> 9 #include <limits>
10 #include <map> 10 #include <map>
(...skipping 594 matching lines...) Expand 10 before | Expand all | Expand 10 after
605 } 605 }
606 606
607 void AutofillManager::OnAddPasswordFormMapping( 607 void AutofillManager::OnAddPasswordFormMapping(
608 const FormFieldData& form, 608 const FormFieldData& form,
609 const PasswordFormFillData& fill_data) { 609 const PasswordFormFillData& fill_data) {
610 external_delegate_->AddPasswordFormMapping(form, fill_data); 610 external_delegate_->AddPasswordFormMapping(form, fill_data);
611 } 611 }
612 612
613 void AutofillManager::OnShowPasswordSuggestions( 613 void AutofillManager::OnShowPasswordSuggestions(
614 const FormFieldData& field, 614 const FormFieldData& field,
615 const PasswordForm& password_form,
vabr (Chromium) 2014/02/05 20:34:20 Please revert all changes in this file and it's *.
615 const gfx::RectF& bounds, 616 const gfx::RectF& bounds,
616 const std::vector<base::string16>& suggestions, 617 const std::vector<base::string16>& suggestions,
617 const std::vector<base::string16>& realms) { 618 const std::vector<base::string16>& realms) {
618 external_delegate_->OnShowPasswordSuggestions(suggestions, 619 external_delegate_->OnShowPasswordSuggestions(suggestions,
619 realms, 620 realms,
620 field, 621 field,
622 password_form,
621 bounds); 623 bounds);
622 } 624 }
623 625
624 void AutofillManager::OnSetDataList(const std::vector<base::string16>& values, 626 void AutofillManager::OnSetDataList(const std::vector<base::string16>& values,
625 const std::vector<base::string16>& labels) { 627 const std::vector<base::string16>& labels) {
626 if (values.size() != labels.size()) 628 if (values.size() != labels.size())
627 return; 629 return;
628 630
629 external_delegate_->SetCurrentDataListValues(values, labels); 631 external_delegate_->SetCurrentDataListValues(values, labels);
630 } 632 }
(...skipping 480 matching lines...) Expand 10 before | Expand all | Expand 10 after
1111 return false; 1113 return false;
1112 1114
1113 // Disregard forms that we wouldn't ever autofill in the first place. 1115 // Disregard forms that we wouldn't ever autofill in the first place.
1114 if (!form.ShouldBeParsed(true)) 1116 if (!form.ShouldBeParsed(true))
1115 return false; 1117 return false;
1116 1118
1117 return true; 1119 return true;
1118 } 1120 }
1119 1121
1120 } // namespace autofill 1122 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698