Allow deleting autofill password suggestions on Shift+Delete

components/autofill/content/renderer/autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "components/autofill/content/renderer/form_autofill_util.h"
 #include "components/autofill/content/renderer/page_click_tracker.h"
 #include "components/autofill/content/renderer/password_autofill_agent.h"
+#include "components/autofill/content/renderer/password_form_conversion_utils.h"
 #include "components/autofill/core/common/autofill_constants.h"
 #include "components/autofill/core/common/autofill_messages.h"
 #include "components/autofill/core/common/autofill_switches.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_data_predictions.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/autofill/core/common/web_element_descriptor.h"
 #include "content/public/common/ssl_status.h"
 #include "content/public/common/url_constants.h"
@@ skipping 517 matching lines @@
   const RequirementsMask requirements =
       element.autoComplete() ? REQUIRE_AUTOCOMPLETE : REQUIRE_NONE;
 
   FormData form;
   FormFieldData field;
   if (!FindFormAndFieldForInputElement(element, &form, &field, requirements)) {
     // If we didn't find the cached form, at least let autocomplete have a shot
     // at providing suggestions.
     WebFormControlElementToFormField(element, EXTRACT_VALUE, &field);
   }
+  scoped_ptr<PasswordForm> password_form(
+      CreatePasswordForm(element.form()));
+  DCHECK(password_form);

[vabr (Chromium), 2014/01/29 16:09:36]

Is QueryAutofillSuggestions also called for non-password web forms? In that
case, the code should handle password_form==NULL.

[riadh.chtara, 2014/02/04 16:22:03]

I'm going to remove it.

 
   gfx::RectF bounding_box_scaled =
       GetScaledBoundingBox(web_view_->pageScaleFactor(), &element_);
 
   // Find the datalist values and send them to the browser process.
   std::vector<base::string16> data_list_values;
   std::vector<base::string16> data_list_labels;
   GetDataListSuggestions(element_, &data_list_values, &data_list_labels);
   TrimStringVectorForIPC(&data_list_values);
   TrimStringVectorForIPC(&data_list_labels);
 
   Send(new AutofillHostMsg_SetDataList(routing_id(),
                                        data_list_values,
                                        data_list_labels));
 
   Send(new AutofillHostMsg_QueryFormFieldAutofill(routing_id(),

[vabr (Chromium), 2014/01/29 16:09:36]

Do you actually need to include the password form here, when you also send add
it to the AutofillHostMsg_ShowPasswordSuggestions message it in the
PasswordAutofillAgent::ShowSuggestionPopup ?

[riadh.chtara, 2014/02/04 16:22:03]

OK, I will remove it.

                                                   autofill_query_id_,
                                                   form,
                                                   field,
+                                                  *password_form,
                                                   bounding_box_scaled,
                                                   display_warning_if_disabled));
 }
 
 void AutofillAgent::FillAutofillFormData(const WebNode& node,
                                          int unique_id,
                                          AutofillAction action) {
   DCHECK_GT(unique_id, 0);
 
   static int query_counter = 0;
@@ skipping 32 matching lines @@
     // Only monitors dynamic forms created in the top frame. Dynamic forms
     // inserted in iframes are not captured yet.
     if (!frame->parent()) {
       password_autofill_agent_->OnDynamicFormsSeen(frame);
       return;
     }
   }
 }
 
 }  // namespace autofill