Allow deleting autofill password suggestions on Shift+Delete

components/autofill/core/common/autofill_messages.h

Index: components/autofill/core/common/autofill_messages.h
diff --git a/components/autofill/core/common/autofill_messages.h b/components/autofill/core/common/autofill_messages.h
index b0b1548d52a88ddee72c88a4f324d5583ac14b7b..6560043d69a0d00a9bec47095aca3fa83cd93b1c 100644
--- a/components/autofill/core/common/autofill_messages.h
+++ b/components/autofill/core/common/autofill_messages.h
@@ -161,6 +161,10 @@ IPC_MESSAGE_ROUTED0(AutofillMsg_PageShown)
 IPC_MESSAGE_ROUTED1(AutofillMsg_AccountCreationFormsDetected,
                     std::vector<autofill::FormData> /* forms */)
 
+// Instruct the renderer that a password mapping has to be removed.

[vabr (Chromium), 2014/03/07 23:43:36]

nit: Not clear what mapping is meant. Could you elaborate?
Also below.

[riadh.chtara, 2014/03/14 17:16:08]

Done.

+IPC_MESSAGE_ROUTED1(AutofillMsg_RemovePasswordSuggestion,
+                    autofill::PasswordForm /* the password form */)

[vabr (Chromium), 2014/03/07 23:43:36]

nit: Maybe rather "password to be removed"?
It's clear that it's a password form, but it's not entirely clear what is the
meaning of it.

[riadh.chtara, 2014/03/14 17:16:08]

Done.

+
 // Autofill messages sent from the renderer to the browser.
 
 // TODO(creis): check in the browser that the renderer actually has permission
@@ -250,12 +254,18 @@ IPC_MESSAGE_ROUTED2(AutofillHostMsg_AddPasswordFormMapping,
 
 // Instruct the browser to show a popup with the following suggestions from the
 // password manager.
-IPC_MESSAGE_ROUTED4(AutofillHostMsg_ShowPasswordSuggestions,
+IPC_MESSAGE_ROUTED5(AutofillHostMsg_ShowPasswordSuggestions,
                     autofill::FormFieldData /* the form field */,
+                    autofill::PasswordForm /* the password form */,
                     gfx::RectF /* input field bounds, window-relative */,
                     std::vector<base::string16> /* suggestions */,
                     std::vector<base::string16> /* realms */)
 
+// Instruct the browser that a password mapping has to be removed.
+IPC_MESSAGE_ROUTED2(AutofillHostMsg_RemovePasswordSuggestion,
+                    autofill::PasswordForm /* the password form */,

[vabr (Chromium), 2014/03/07 23:43:36]

Please explain the meaning of the arguments. Especially the vector of forms.

[riadh.chtara, 2014/03/14 17:16:08]

Done.

+                    std::vector<autofill::PasswordForm>)
+
 // Inform browser of data list values for the curent field.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList,
                     std::vector<base::string16> /* values */,