Allow deleting autofill password suggestions on Shift+Delete

components/autofill/core/common/autofill_messages.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, hence no include guard.
 
 #include <string>
 
 #include "base/time/time.h"
 #include "components/autofill/core/common/autofill_param_traits_macros.h"
@@ skipping 143 matching lines @@
 
 // Sent when the current page is actually displayed in the browser, possibly
 // after being preloaded.
 IPC_MESSAGE_ROUTED0(AutofillMsg_PageShown)
 
 // Sent when Autofill manager gets the query response from the Autofill server
 // and there are fields classified as ACCOUNT_CREATION_PASSWORD in the response.
 IPC_MESSAGE_ROUTED1(AutofillMsg_AccountCreationFormsDetected,
                     std::vector<autofill::FormData> /* forms */)
 
+// Instruct the renderer that a password mapping has to be removed.

[vabr (Chromium), 2014/03/07 23:43:36]

nit: Not clear what mapping is meant. Could you elaborate?
Also below.

[riadh.chtara, 2014/03/14 17:16:08]

Done.

+IPC_MESSAGE_ROUTED1(AutofillMsg_RemovePasswordSuggestion,
+                    autofill::PasswordForm /* the password form */)

[vabr (Chromium), 2014/03/07 23:43:36]

nit: Maybe rather "password to be removed"?
It's clear that it's a password form, but it's not entirely clear what is the
meaning of it.

[riadh.chtara, 2014/03/14 17:16:08]

Done.

+
 // Autofill messages sent from the renderer to the browser.
 
 // TODO(creis): check in the browser that the renderer actually has permission
 // for the URL to avoid compromised renderers talking to the browser.
 
 // Notification that forms have been seen that are candidates for
 // filling/submitting by the AutofillManager.
 IPC_MESSAGE_ROUTED3(AutofillHostMsg_FormsSeen,
                     std::vector<autofill::FormData> /* forms */,
                     base::TimeTicks /* timestamp */,
@@ skipping 69 matching lines @@
                     int /* max length of the password */,
                     autofill::PasswordForm)
 
 // Instruct the browser that a password mapping has been found for a field.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_AddPasswordFormMapping,
                     autofill::FormFieldData, /* the user name field */
                     autofill::PasswordFormFillData /* password pairings */)
 
 // Instruct the browser to show a popup with the following suggestions from the
 // password manager.
-IPC_MESSAGE_ROUTED4(AutofillHostMsg_ShowPasswordSuggestions,
+IPC_MESSAGE_ROUTED5(AutofillHostMsg_ShowPasswordSuggestions,
                     autofill::FormFieldData /* the form field */,
+                    autofill::PasswordForm /* the password form */,
                     gfx::RectF /* input field bounds, window-relative */,
                     std::vector<base::string16> /* suggestions */,
                     std::vector<base::string16> /* realms */)
 
+// Instruct the browser that a password mapping has to be removed.
+IPC_MESSAGE_ROUTED2(AutofillHostMsg_RemovePasswordSuggestion,
+                    autofill::PasswordForm /* the password form */,

[vabr (Chromium), 2014/03/07 23:43:36]

Please explain the meaning of the arguments. Especially the vector of forms.

[riadh.chtara, 2014/03/14 17:16:08]

Done.

+                    std::vector<autofill::PasswordForm>)
+
 // Inform browser of data list values for the curent field.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList,
                     std::vector<base::string16> /* values */,
                     std::vector<base::string16> /* labels */)