components/autofill/core/browser/autofill_external_delegate_unittest.cc - Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate_unittest.cc

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleaning the code Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/browser/autofill_driver_impl.cc ('K') | « components/autofill/core/browser/autofill_external_delegate.cc ('k') | components/autofill/core/browser/autofill_manager.h » ('j') | components/autofill/core/common/autofill_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_external_delegate_unittest.cc

diff --git a/components/autofill/core/browser/autofill_external_delegate_unittest.cc b/components/autofill/core/browser/autofill_external_delegate_unittest.cc

index fe0f6f712747a02e90f9a81c4158466ea234d1e0..aff373ae05d820e5f5b768e7f9a509283caf1996 100644

--- a/components/autofill/core/browser/autofill_external_delegate_unittest.cc

+++ b/components/autofill/core/browser/autofill_external_delegate_unittest.cc

@@ -421,10 +421,9 @@ TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegatePasswordSuggestions) {

WebAutofillClient::MenuItemIDPasswordEntry)),

_));

- external_delegate_->OnShowPasswordSuggestions(suggestions,

- realms,

- field,

- element_bounds);

+ PasswordForm password_form;

+ external_delegate_->OnShowPasswordSuggestions(

+ suggestions, realms, field, password_form, element_bounds);

EXPECT_CALL(manager_delegate_, HideAutofillPopup());