Allow deleting autofill password suggestions on Shift+Delete

chrome/browser/password_manager/password_form_manager.h

Index: chrome/browser/password_manager/password_form_manager.h
diff --git a/chrome/browser/password_manager/password_form_manager.h b/chrome/browser/password_manager/password_form_manager.h
index 53fbe747f4798e22830b746f81e4d63aec3d5356..11524c47878282cd754c3c052ccbe8905cb41b27 100644
--- a/chrome/browser/password_manager/password_form_manager.h
+++ b/chrome/browser/password_manager/password_form_manager.h
@@ -93,9 +93,11 @@ class PasswordFormManager : public PasswordStoreConsumer {
   bool HasGeneratedPassword();
   void SetHasGeneratedPassword();
 
+  void RemoveAndUpdate(const string16& to_remove_username);
+  void Update(const string16& username_to_remove);
+
   // Determines if we need to autofill given the results of the query.
   void OnRequestDone(const std::vector<autofill::PasswordForm*>& result);

[vabr (Chromium), 2014/03/07 23:43:36]

nit: please return the blank line below

[riadh.chtara, 2014/03/14 17:16:08]

Done.

-
   // PasswordStoreConsumer implementation.
   virtual void OnPasswordStoreRequestDone(
       CancelableRequestProvider::Handle handle,
@@ -268,6 +270,10 @@ class PasswordFormManager : public PasswordStoreConsumer {
   // Whether this form has an auto generated password.
   bool has_generated_password_;
 
+  bool remover_;

[vabr (Chromium), 2014/03/07 23:43:36]

What about getting rid of |remover_|, and using username_to_remove_ emptiness to
mean remover_ == false?
Also, I suggest renaming |only_update_| to |remove_candidate_from_store_| (this
would negate the meaning, so code needs to be changed after the rename).
Plus, there needs to be a comment explaining when these two variables are used.

In any case, the names need to change a bit: A variable of type bool is a yes/no
piece of information. A variable called |remover_| sounds like a whole object
doing some removing.

The name |only_update_| does not specify what is to be updated and when.

[riadh.chtara, 2014/03/14 17:16:08]

Done.

+  bool only_update_;
+  string16 username_to_remove_;
+
   // Set if the user has selected one of the other possible usernames in
   // |pending_credentials_|.
   string16 selected_username_;