Allow deleting autofill password suggestions on Shift+Delete

chrome/browser/password_manager/password_form_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 75 matching lines @@
 
   // Checks if the form is a valid password form. Forms which lack either
   // login or password field are not considered valid.
   bool HasValidPasswordForm();
 
   // These functions are used to determine if this form has had it's password
   // auto generated by the browser.
   bool HasGeneratedPassword();
   void SetHasGeneratedPassword();
 
+  void RemoveAndUpdate(const string16& to_remove_username);
+  void Update(const string16& username_to_remove);
+
   // Determines if we need to autofill given the results of the query.
   void OnRequestDone(const std::vector<autofill::PasswordForm*>& result);

[vabr (Chromium), 2014/03/07 23:43:36]

nit: please return the blank line below

[riadh.chtara, 2014/03/14 17:16:08]

Done.

-
   // PasswordStoreConsumer implementation.
   virtual void OnPasswordStoreRequestDone(
       CancelableRequestProvider::Handle handle,
       const std::vector<autofill::PasswordForm*>& result) OVERRIDE;
   virtual void OnGetPasswordStoreResults(
       const std::vector<autofill::PasswordForm*>& results) OVERRIDE;
 
   // A user opted to 'never remember' passwords for this form.
   // Blacklist it so that from now on when it is seen we ignore it.
   // TODO: Make this private once we switch to the new UI.
@@ skipping 152 matching lines @@
   // still unknown.
   autofill::PasswordForm pending_credentials_;
 
   // Whether pending_credentials_ stores a new login or is an update
   // to an existing one.
   bool is_new_login_;
 
   // Whether this form has an auto generated password.
   bool has_generated_password_;
 
+  bool remover_;

[vabr (Chromium), 2014/03/07 23:43:36]

What about getting rid of |remover_|, and using username_to_remove_ emptiness to
mean remover_ == false?
Also, I suggest renaming |only_update_| to |remove_candidate_from_store_| (this
would negate the meaning, so code needs to be changed after the rename).
Plus, there needs to be a comment explaining when these two variables are used.

In any case, the names need to change a bit: A variable of type bool is a yes/no
piece of information. A variable called |remover_| sounds like a whole object
doing some removing.

The name |only_update_| does not specify what is to be updated and when.

[riadh.chtara, 2014/03/14 17:16:08]

Done.

+  bool only_update_;
+  string16 username_to_remove_;
+
   // Set if the user has selected one of the other possible usernames in
   // |pending_credentials_|.
   string16 selected_username_;
 
   // PasswordManager owning this.
   const PasswordManager* const password_manager_;
 
   // Convenience pointer to entry in best_matches_ that is marked
   // as preferred. This is only allowed to be null if there are no best matches
   // at all, since there will always be one preferred login when there are
@@ skipping 24 matching lines @@
   // These three fields record the "ActionsTaken" by the browser and
   // the user with this form, and the result. They are combined and
   // recorded in UMA when the manager is destroyed.
   ManagerAction manager_action_;
   UserAction user_action_;
   SubmitResult submit_result_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordFormManager);
 };
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_