Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index 22ec8be61893c33aa0bae1a85613c3fa0eeaf2ea..fd84764af56219ff1b3efac9dd1b5211d0f6cffd 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -46,6 +46,7 @@
#include "content/public/browser/web_contents.h"
#include "grit/component_strings.h"
#include "third_party/WebKit/public/web/WebAutofillClient.h"
+#include "third_party/WebKit/public/web/WebFormElement.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/gfx/rect.h"
#include "url/gurl.h"
@@ -355,10 +356,11 @@ void AutofillManager::OnTextFieldDidChange(const FormData& form,
}
void AutofillManager::OnQueryFormFieldAutofill(int query_id,
- const FormData& form,
- const FormFieldData& field,
- const gfx::RectF& bounding_box,
- bool display_warning) {
+ const FormData& form,
vabr (Chromium) 2014/01/10 18:40:00 Wrong indentation, should match the column positio
+ const FormFieldData& field,
+ const blink::WebFormElement& webformelement,
+ const gfx::RectF& bounding_box,
+ bool display_warning) {
std::vector<base::string16> values;
std::vector<base::string16> labels;
std::vector<base::string16> icons;
@@ -367,6 +369,7 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
external_delegate_->OnQuery(query_id,
form,
field,
+ webformelement,
bounding_box,
display_warning);
@@ -612,10 +615,12 @@ void AutofillManager::OnAddPasswordFormMapping(
void AutofillManager::OnShowPasswordSuggestions(
const FormFieldData& field,
+ const blink::WebFormElement& element,
const gfx::RectF& bounds,
const std::vector<base::string16>& suggestions,
const std::vector<base::string16>& realms) {
external_delegate_->OnShowPasswordSuggestions(suggestions,
+ element,
realms,
field,
bounds);

Powered by Google App Engine
This is Rietveld 408576698