Allow deleting autofill password suggestions on Shift+Delete

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 28 matching lines @@
 #include "components/autofill/core/common/autofill_pref_names.h"
 #include "components/autofill/core/common/autofill_switches.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_data_predictions.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "components/autofill/core/common/password_form_fill_data.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "content/public/browser/web_contents.h"
 #include "grit/component_strings.h"
 #include "third_party/WebKit/public/web/WebAutofillClient.h"
+#include "third_party/WebKit/public/web/WebFormElement.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/rect.h"
 #include "url/gurl.h"
 
 namespace autofill {
 
 typedef PersonalDataManager::GUIDPair GUIDPair;
 
 using base::TimeTicks;
 using content::RenderViewHost;
@@ skipping 289 matching lines @@
       user_did_edit_autofilled_field_ = true;
       metric_logger_->LogUserHappinessMetric(
           AutofillMetrics::USER_DID_EDIT_AUTOFILLED_FIELD_ONCE);
     }
   }
 
   UpdateInitialInteractionTimestamp(timestamp);
 }
 
 void AutofillManager::OnQueryFormFieldAutofill(int query_id,
-                                               const FormData& form,
-                                               const FormFieldData& field,
-                                               const gfx::RectF& bounding_box,
-                                               bool display_warning) {
+    const FormData& form,

[vabr (Chromium), 2014/01/10 18:40:00]

Wrong indentation, should match the column position of "int query_id".

Have you been able to use clang-format? In particular, in the form of "git cl
format", it will autoformat all your changes.

+    const FormFieldData& field,
+    const blink::WebFormElement& webformelement,
+    const gfx::RectF& bounding_box,
+    bool display_warning) {
   std::vector<base::string16> values;
   std::vector<base::string16> labels;
   std::vector<base::string16> icons;
   std::vector<int> unique_ids;
 
   external_delegate_->OnQuery(query_id,
                               form,
                               field,
+                              webformelement,
                               bounding_box,
                               display_warning);
 
   RenderViewHost* host = NULL;
   FormStructure* form_structure = NULL;
   AutofillField* autofill_field = NULL;
   if (GetHost(&host) &&
       GetCachedFormAndField(form, field, &form_structure, &autofill_field) &&
       // Don't send suggestions for forms that aren't auto-fillable.
       form_structure->IsAutofillable(false)) {
@@ skipping 225 matching lines @@
 }
 
 void AutofillManager::OnAddPasswordFormMapping(
       const FormFieldData& form,
       const PasswordFormFillData& fill_data) {
   external_delegate_->AddPasswordFormMapping(form, fill_data);
 }
 
 void AutofillManager::OnShowPasswordSuggestions(
     const FormFieldData& field,
+    const blink::WebFormElement& element,
     const gfx::RectF& bounds,
     const std::vector<base::string16>& suggestions,
     const std::vector<base::string16>& realms) {
   external_delegate_->OnShowPasswordSuggestions(suggestions,
+                                                element,
                                                 realms,
                                                 field,
                                                 bounds);
 }
 
 void AutofillManager::OnSetDataList(const std::vector<base::string16>& values,
                                     const std::vector<base::string16>& labels) {
   if (values.size() != labels.size())
     return;
 
@@ skipping 482 matching lines @@
     return false;
 
   // Disregard forms that we wouldn't ever autofill in the first place.
   if (!form.ShouldBeParsed(true))
     return false;
 
   return true;
 }
 
 }  // namespace autofill