Allow deleting autofill password suggestions on Shift+Delete

chrome/browser/password_manager/password_manager.cc

Index: chrome/browser/password_manager/password_manager.cc
diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc
index 80392991c52f996d95743a3daab91cdd69e6fb07..6a402fa4ad94414f637e2ab637d2c8ed70736cac 100644
--- a/chrome/browser/password_manager/password_manager.cc
+++ b/chrome/browser/password_manager/password_manager.cc
@@ -10,10 +10,11 @@
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
-#include "base/threading/platform_thread.h"

[vabr (Chromium), 2014/01/10 18:40:00]

Don't remove this header, it declares, e.g., PlatformThreadId, which is used
below.

 #include "chrome/browser/password_manager/password_form_manager.h"
 #include "chrome/browser/password_manager/password_manager_delegate.h"
 #include "chrome/browser/password_manager/password_manager_metrics_util.h"
+#include "chrome/browser/password_manager/password_store.h"
+#include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h"
 #include "chrome/common/chrome_switches.h"
@@ -263,6 +264,8 @@ bool PasswordManager::OnMessageReceived(const IPC::Message& message) {
                         OnPasswordFormsRendered)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_PasswordFormSubmitted,
                         OnPasswordFormSubmitted)
+    IPC_MESSAGE_HANDLER(AutofillHostMsg_RemovePasswordSuggestion,
+                        OnRemovePasswordSuggestion)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
@@ -352,6 +355,14 @@ void PasswordManager::OnPasswordFormsRendered(
   }
 }
 
+void PasswordManager::OnRemovePasswordSuggestion(
+    const PasswordForm& password_form) {

[vabr (Chromium), 2014/01/10 18:40:00]

"const PasswordForm&" does not match the argument type of
AutofillHostMes_RemovePasswordSuggestion, which is blink::WebFormElement.

These are very different types (PasswordForm is a structure holding login
credentials, WebFormElement represents a <FORM> HTML element).

You need to create PasswordForm from WebFormElement first, and preferably before
sending anything, so that you can avoid touching blink:: objects.

+  PasswordStore* password_store = PasswordStoreFactory::GetForProfile(

[vabr (Chromium), 2014/01/10 18:40:00]

Please either make password_store a scoped_refptr<PasswordStore>, or call
RemoveLogin() directly on the result of GetForProfile().

+      delegate_->GetProfile(), Profile::EXPLICIT_ACCESS).get();
+  password_store->RemoveLogin(password_form)
+

[vabr (Chromium), 2014/01/10 18:40:00]

nit: Please remove this empty line.

+}
+
 void PasswordManager::PossiblyInitializeUsernamesExperiment(
     const PasswordFormMap& best_matches) const {
   if (base::FieldTrialList::Find(kOtherPossibleUsernamesExperiment))