Allow deleting autofill password suggestions on Shift+Delete

chrome/browser/password_manager/password_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_manager.h"
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
-#include "base/threading/platform_thread.h"

[vabr (Chromium), 2014/01/10 18:40:00]

Don't remove this header, it declares, e.g., PlatformThreadId, which is used
below.

 #include "chrome/browser/password_manager/password_form_manager.h"
 #include "chrome/browser/password_manager/password_manager_delegate.h"
 #include "chrome/browser/password_manager/password_manager_metrics_util.h"
+#include "chrome/browser/password_manager/password_store.h"
+#include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/pref_names.h"
 #include "components/autofill/core/common/autofill_messages.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
@@ skipping 229 matching lines @@
 
 bool PasswordManager::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(PasswordManager, message)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_PasswordFormsParsed,
                         OnPasswordFormsParsed)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_PasswordFormsRendered,
                         OnPasswordFormsRendered)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_PasswordFormSubmitted,
                         OnPasswordFormSubmitted)
+    IPC_MESSAGE_HANDLER(AutofillHostMsg_RemovePasswordSuggestion,
+                        OnRemovePasswordSuggestion)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void PasswordManager::OnPasswordFormSubmitted(
     const PasswordForm& password_form) {
   ProvisionallySavePassword(password_form);
   for (size_t i = 0; i < submission_callbacks_.size(); ++i) {
     submission_callbacks_[i].Run(password_form);
@@ skipping 69 matching lines @@
     } else {
       delegate_->AddSavePasswordInfoBarIfPermitted(
           provisional_save_manager_.release());
     }
   } else {
     provisional_save_manager_->Save();
     provisional_save_manager_.reset();
   }
 }
 
+void PasswordManager::OnRemovePasswordSuggestion(
+    const PasswordForm& password_form) {

[vabr (Chromium), 2014/01/10 18:40:00]

"const PasswordForm&" does not match the argument type of
AutofillHostMes_RemovePasswordSuggestion, which is blink::WebFormElement.

These are very different types (PasswordForm is a structure holding login
credentials, WebFormElement represents a <FORM> HTML element).

You need to create PasswordForm from WebFormElement first, and preferably before
sending anything, so that you can avoid touching blink:: objects.

+  PasswordStore* password_store = PasswordStoreFactory::GetForProfile(

[vabr (Chromium), 2014/01/10 18:40:00]

Please either make password_store a scoped_refptr<PasswordStore>, or call
RemoveLogin() directly on the result of GetForProfile().

+      delegate_->GetProfile(), Profile::EXPLICIT_ACCESS).get();
+  password_store->RemoveLogin(password_form)
+

[vabr (Chromium), 2014/01/10 18:40:00]

nit: Please remove this empty line.

+}
+
 void PasswordManager::PossiblyInitializeUsernamesExperiment(
     const PasswordFormMap& best_matches) const {
   if (base::FieldTrialList::Find(kOtherPossibleUsernamesExperiment))
     return;
 
   bool other_possible_usernames_exist = false;
   for (autofill::PasswordFormMap::const_iterator it = best_matches.begin();
        it != best_matches.end(); ++it) {
     if (!it->second->other_possible_usernames.empty()) {
       other_possible_usernames_exist = true;
@@ skipping 59 matching lines @@
   }
 
   ManagePasswordsBubbleUIController* manage_passwords_bubble_ui_controller =
       ManagePasswordsBubbleUIController::FromWebContents(web_contents());
   if (manage_passwords_bubble_ui_controller &&
       CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableSavePasswordBubble)) {
     manage_passwords_bubble_ui_controller->OnPasswordAutofilled(best_matches);
   }
 }