Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1338853002: Revert 202146 "Don't allow whitespace between elements with disp..." (Closed)

Created:
5 years, 3 months ago by amineer
Modified:
5 years, 3 months ago
Reviewers:
rhogan
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Visibility:
Public.

Description

Revert 202146 "Don't allow whitespace between elements with disp..." Looks to be breaking the build: c:\b\build\slave\win_stable\build\src\third_party\webkit\source\core\dom\text.cpp(259) : error C3861: 'isHTMLTableCellElement': identifier not found > Don't allow whitespace between elements with display:table-cell > > In https://codereview.chromium.org/1065563005 we started allowing whitespace > inside anonymous table cells. We're only interested in anonymous table cells > that were generated to contain non-table-part content. If the anonymous cell > was generated to contain a form element with display:table-cell, for example, then > that is not a situation where we want to treat any whitespace before and > after the form element as renderable. > > BUG=515771 > > TBR=mstensho@opera.com > > Review URL: https://codereview.chromium.org/1280123004 > > (cherry picked from commit 6ec7d5542348b58494890327d8d53caec8e89f25) > > Review URL: https://codereview.chromium.org/1334373002 . TBR=robhogan@gmail.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202158

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -150 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/table/table-row-before-after-content-around-table-cell-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
D LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display.html View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-2.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-2-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-3.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-3-expected.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-4.html View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-4-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-expected.html View 1 chunk +0 lines, -25 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug2479-1-expected.txt View 3 chunks +13 lines, -0 lines 0 comments Download
M Source/core/dom/Text.cpp View 3 chunks +8 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
amineer
5 years, 3 months ago (2015-09-11 19:37:24 UTC) #1
amineer
5 years, 3 months ago (2015-09-11 19:37:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r202158.

Powered by Google App Engine
This is Rietveld 408576698