Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1334373002: Don't allow whitespace between elements with display:table-cell (Closed)

Created:
5 years, 3 months ago by rhogan
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Target Ref:
refs/branch-heads/chromium/2454
Project:
blink
Visibility:
Public.

Description

Don't allow whitespace between elements with display:table-cell In https://codereview.chromium.org/1065563005 we started allowing whitespace inside anonymous table cells. We're only interested in anonymous table cells that were generated to contain non-table-part content. If the anonymous cell was generated to contain a form element with display:table-cell, for example, then that is not a situation where we want to treat any whitespace before and after the form element as renderable. BUG=515771 TBR=mstensho@opera.com Review URL: https://codereview.chromium.org/1280123004 git-svn-id: svn://svn.chromium.org/blink/trunk@201329 bbb929c8-8fbe-4397-9dbb-9b2b20218538 (cherry picked from commit 6ec7d5542348b58494890327d8d53caec8e89f25) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -23 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/table/table-row-before-after-content-around-table-cell-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
A LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display.html View 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-2.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-2-expected.html View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-3.html View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-3-expected.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-4.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-4-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-expected.html View 1 chunk +25 lines, -0 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug2479-1-expected.txt View 2 chunks +0 lines, -13 lines 0 comments Download
M Source/core/dom/Text.cpp View 3 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
rhogan
5 years, 3 months ago (2015-09-11 17:08:54 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 202146 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698