Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 133873004: aura: Remove Window::SetHitTestBoundsOverrideOuter() and related methods. (Closed)

Created:
6 years, 11 months ago by sadrul
Modified:
6 years, 10 months ago
CC:
chromium-reviews, ben+aura_chromium.org, tfarina, chromium-apps-reviews_chromium.org, kalyank, ben+ash_chromium.org
Visibility:
Public.

Description

aura: Remove Window::SetHitTestBoundsOverrideOuter() and related methods. Event-targeters (e.g. wm::EasyResizeWindowTargeter) now do the necessary work for allowing a window to receive events outside of its bounds. So these methods on aura::Window are no longer necessary. BUG=318879 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247821

Patch Set 1 #

Patch Set 2 : tot-merge-r247521 #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -112 lines) Patch
M apps/ui/views/shell_window_frame_view.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M apps/ui/views/shell_window_frame_view.cc View 1 2 4 chunks +7 lines, -20 lines 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 2 chunks +0 lines, -21 lines 0 comments Download
M ash/wm/frame_border_hit_test_controller.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/aura/window.h View 2 chunks +1 line, -21 lines 0 comments Download
M ui/aura/window.cc View 1 chunk +1 line, -7 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M ui/oak/oak_aura_window_display.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sadrul
6 years, 11 months ago (2014-01-27 23:41:24 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 11 months ago (2014-01-28 00:56:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sadrul@chromium.org/133873004/120001
6 years, 10 months ago (2014-01-29 05:14:00 UTC) #3
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=42984
6 years, 10 months ago (2014-01-29 11:59:31 UTC) #4
sadrul
6 years, 10 months ago (2014-01-30 03:54:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r247821 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698