chrome/browser/media/router/issue.h - Issue 1338713003: Return const by ref instead of const by value in Issue:id()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/issue.h

Issue 1338713003: Return const by ref instead of const by value in Issue:id() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/media/router/issue.h

diff --git a/chrome/browser/media/router/issue.h b/chrome/browser/media/router/issue.h

index 3da2443dd64cb942c62690debf60ce0a30aebe00..e254a0ac1685d18454fb964fbd17e6812aeacd62 100644

--- a/chrome/browser/media/router/issue.h

+++ b/chrome/browser/media/router/issue.h

@@ -73,7 +73,7 @@ class Issue {

}

MediaRoute::Id route_id() const { return route_id_; }

Severity severity() const { return severity_; }

- const Issue::Id id() const { return id_; }

+ const Issue::Id& id() const { return id_; }

bool is_blocking() const { return is_blocking_; }

bool is_global() const { return route_id_.empty(); }

const GURL& help_url() const { return help_url_; }

« no previous file with comments | « no previous file | no next file » | no next file with comments »