Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: chrome/browser/media/router/issue.h

Issue 1338713003: Return const by ref instead of const by value in Issue:id() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_MEDIA_ROUTER_ISSUE_H_ 5 #ifndef CHROME_BROWSER_MEDIA_ROUTER_ISSUE_H_
6 #define CHROME_BROWSER_MEDIA_ROUTER_ISSUE_H_ 6 #define CHROME_BROWSER_MEDIA_ROUTER_ISSUE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 66
67 // See constructor comments for more information about these fields. 67 // See constructor comments for more information about these fields.
68 const std::string& title() const { return title_; } 68 const std::string& title() const { return title_; }
69 const std::string& message() const { return message_; } 69 const std::string& message() const { return message_; }
70 IssueAction default_action() const { return default_action_; } 70 IssueAction default_action() const { return default_action_; }
71 const std::vector<IssueAction>& secondary_actions() const { 71 const std::vector<IssueAction>& secondary_actions() const {
72 return secondary_actions_; 72 return secondary_actions_;
73 } 73 }
74 MediaRoute::Id route_id() const { return route_id_; } 74 MediaRoute::Id route_id() const { return route_id_; }
75 Severity severity() const { return severity_; } 75 Severity severity() const { return severity_; }
76 const Issue::Id id() const { return id_; } 76 const Issue::Id& id() const { return id_; }
77 bool is_blocking() const { return is_blocking_; } 77 bool is_blocking() const { return is_blocking_; }
78 bool is_global() const { return route_id_.empty(); } 78 bool is_global() const { return route_id_.empty(); }
79 const GURL& help_url() const { return help_url_; } 79 const GURL& help_url() const { return help_url_; }
80 80
81 bool Equals(const Issue& other) const; 81 bool Equals(const Issue& other) const;
82 82
83 private: 83 private:
84 std::string title_; 84 std::string title_;
85 std::string message_; 85 std::string message_;
86 IssueAction default_action_; 86 IssueAction default_action_;
87 std::vector<IssueAction> secondary_actions_; 87 std::vector<IssueAction> secondary_actions_;
88 std::string route_id_; 88 std::string route_id_;
89 Severity severity_; 89 Severity severity_;
90 Issue::Id id_; 90 Issue::Id id_;
91 bool is_blocking_; 91 bool is_blocking_;
92 GURL help_url_; 92 GURL help_url_;
93 }; 93 };
94 94
95 } // namespace media_router 95 } // namespace media_router
96 96
97 #endif // CHROME_BROWSER_MEDIA_ROUTER_ISSUE_H_ 97 #endif // CHROME_BROWSER_MEDIA_ROUTER_ISSUE_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698