Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1338483002: Enable nacl on 32-bit x86 linux GN builds. (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 3 months ago
Reviewers:
Petr Hosek, brettw
CC:
chromium-reviews, Roland McGrath
Base URL:
https://chromium.googlesource.com/chromium/src.git@nacl_x86
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable nacl on 32-bit x86 linux GN builds. It looks like the only thing missing at this point was to correct the path to the host build of tls_edit when linking the IRT. R=brettw@chromium.org, phosek@chromium.org BUG=512882 Committed: https://crrev.com/a512a524d8541b52c0a0a264215d3499ec1bbb1d Cr-Commit-Position: refs/heads/master@{#348302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M build/config/features.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/toolchain/nacl/BUILD.gn View 1 chunk +8 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (1 generated)
Dirk Pranke
5 years, 3 months ago (2015-09-10 20:51:00 UTC) #1
Petr Hosek
lgtm
5 years, 3 months ago (2015-09-10 20:54:04 UTC) #2
brettw
lgtm
5 years, 3 months ago (2015-09-10 22:58:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338483002/1
5 years, 3 months ago (2015-09-11 00:18:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 00:46:01 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a512a524d8541b52c0a0a264215d3499ec1bbb1d Cr-Commit-Position: refs/heads/master@{#348302}
5 years, 3 months ago (2015-09-11 00:46:56 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:17:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a512a524d8541b52c0a0a264215d3499ec1bbb1d
Cr-Commit-Position: refs/heads/master@{#348302}

Powered by Google App Engine
This is Rietveld 408576698