Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1332073002: Fix Linux installer dependencies on nacl_helper. (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 3 months ago
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_nacl_build_for_chrome
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Linux installer dependencies on nacl_helper. if nacl was disabled, the installer would still pull in a dependency on nacl_helper, causing build issues. R=brettw@chromium.org, phosek@chromium.org BUG=512882 Committed: https://crrev.com/3b87061e3f88ec64b3a07ce71ac5300fb38c8fd4 Cr-Commit-Position: refs/heads/master@{#348285}

Patch Set 1 : patch for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/installer/linux/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1338453002 Patch 1

Dependent Patchsets:

Issue 1338483002 Patch 1

Messages

Total messages: 16 (5 generated)
Dirk Pranke
5 years, 3 months ago (2015-09-10 20:34:11 UTC) #2
Petr Hosek
lgtm
5 years, 3 months ago (2015-09-10 20:53:50 UTC) #3
brettw
lgtm
5 years, 3 months ago (2015-09-10 23:00:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332073002/20001
5 years, 3 months ago (2015-09-10 23:03:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/98424)
5 years, 3 months ago (2015-09-10 23:15:55 UTC) #8
Dirk Pranke
thestig - Can I get an OWNERS approval?
5 years, 3 months ago (2015-09-10 23:19:46 UTC) #10
Lei Zhang
lgtm
5 years, 3 months ago (2015-09-10 23:29:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332073002/20001
5 years, 3 months ago (2015-09-10 23:30:07 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 3 months ago (2015-09-10 23:42:24 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3b87061e3f88ec64b3a07ce71ac5300fb38c8fd4 Cr-Commit-Position: refs/heads/master@{#348285}
5 years, 3 months ago (2015-09-10 23:43:27 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:16:27 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3b87061e3f88ec64b3a07ce71ac5300fb38c8fd4
Cr-Commit-Position: refs/heads/master@{#348285}

Powered by Google App Engine
This is Rietveld 408576698