be sure to use cached bitmap when we need to upload something to make a texture

be sure to use cached bitmap when we need to upload something to make a texture

BUG=skia:4334
Committed: https://skia.googlesource.com/skia/+/995b4bddd9a1eef933b0acb3ff03c98e7864a8f9

[reed1, 2015-09-14 17:14:32]

reed@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[reed1, 2015-09-14 17:14:32]

ptal

[reed1, 2015-09-14 17:14:35]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-14 17:14:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1338373002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1338373002/1

[commit-bot: I haz the power, 2015-09-14 17:20:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 17:20:38]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-09-14 17:26:28]

lgtm

[reed1, 2015-09-14 17:27:10]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-09-14 17:27:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1338373002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1338373002/1

[commit-bot: I haz the power, 2015-09-14 17:28:00]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/995b4bddd9a1eef933b0acb3ff03c98e7864a8f9

[tomhudson, 2015-09-14 17:31:45]

tomhudson@google.com changed reviewers:
+ tomhudson@google.com

[tomhudson, 2015-09-14 17:31:46]

Noisy sheriff is noisy.

https://codereview.chromium.org/1338373002/diff/1/src/core/SkImageCacherator.cpp
File src/core/SkImageCacherator.cpp (right):

https://codereview.chromium.org/1338373002/diff/1/src/core/SkImageCacherator....
src/core/SkImageCacherator.cpp:74: // If you want the immutable bitmap with the
same ID as our cacherator, call tryLockAsBitmap()
Is there some way we could change the names of these functions to make the very
different semantics clearer? Or are there Skia naming conventions documented
somewhere that would clue us in to this difference?

(Could we put a comment about a critical difference like this INTO THE HEADER,
which is what I'll be reading if I'm trying to figure out how to use the class?)

[reed1, 2015-09-14 17:34:42]

On 2015/09/14 17:31:46, tomhudson wrote:
> Noisy sheriff is noisy.
> 
>
https://codereview.chromium.org/1338373002/diff/1/src/core/SkImageCacherator.cpp
> File src/core/SkImageCacherator.cpp (right):
> 
>
https://codereview.chromium.org/1338373002/diff/1/src/core/SkImageCacherator....
> src/core/SkImageCacherator.cpp:74: // If you want the immutable bitmap with
the
> same ID as our cacherator, call tryLockAsBitmap()
> Is there some way we could change the names of these functions to make the
very
> different semantics clearer? Or are there Skia naming conventions documented
> somewhere that would clue us in to this difference?
> 
> (Could we put a comment about a critical difference like this INTO THE HEADER,
> which is what I'll be reading if I'm trying to figure out how to use the
class?)

Sure, though both of these are private, and only called by the impl itself.