Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 1338293002: Revert of Never consolidate data in ICO decoder (Closed)

Created:
5 years, 3 months ago by scroggo
Modified:
5 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@FastSharedBuffer
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Never consolidate data in ICO decoder (patchset #3 id:40001 of https://codereview.chromium.org/1316203008/ ) Reason for revert: Causing crbug.com/530279. Will reland once I have fixed the problem. Will next revert crrev.com/1259083003 (otherwise crbug.com/528625 will show back up). I will reland both CLs together as one CL that fixes the problems. Original issue's description: > Never consolidate data in ICO decoder > > Follows the same approach as BMPImageDecoder: Use a > FastSharedBufferReader to avoid consolidation. > > Add an optional offset to PNGImageDecoder for ICOImageDecoder, so that > PNGImageDecoder can read a PNG subimage in an ICO without copying the > data. This eliminates another call to SharedBuffer::data(), as well as > a copy to create the separate SharedBuffer for PNG. > > BUG=467772 > BUG=528625 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201981 TBR=pkasting@chromium.org,noel@chromium.org,scroggo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467772 Committed: https://crrev.com/05865c1b34b6c653b893b6f8bce7b86ddafadc4d git-svn-id: svn://svn.chromium.org/blink/trunk@202198 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -43 lines) Patch
M Source/platform/image-decoders/ico/ICOImageDecoder.h View 3 chunks +4 lines, -15 lines 0 comments Download
M Source/platform/image-decoders/ico/ICOImageDecoder.cpp View 7 chunks +20 lines, -21 lines 0 comments Download
M Source/platform/image-decoders/png/PNGImageDecoder.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/platform/image-decoders/png/PNGImageDecoder.cpp View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
scroggo
Created Revert of Never consolidate data in ICO decoder
5 years, 3 months ago (2015-09-14 13:27:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338293002/1
5 years, 3 months ago (2015-09-14 13:27:31 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-14 13:27:33 UTC) #4
Noel Gordon
LGTM
5 years, 3 months ago (2015-09-14 13:34:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338293002/1
5 years, 3 months ago (2015-09-14 13:35:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202198
5 years, 3 months ago (2015-09-14 13:35:36 UTC) #8
Peter Kasting
LGTM
5 years, 3 months ago (2015-09-14 19:43:26 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:31:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05865c1b34b6c653b893b6f8bce7b86ddafadc4d

Powered by Google App Engine
This is Rietveld 408576698