DescriptionRevert of Never consolidate data in ICO decoder (patchset #3 id:40001 of https://codereview.chromium.org/1316203008/ )
Reason for revert:
Causing crbug.com/530279. Will reland once I have fixed the problem.
Will next revert crrev.com/1259083003 (otherwise crbug.com/528625 will show back up).
I will reland both CLs together as one CL that fixes the problems.
Original issue's description:
> Never consolidate data in ICO decoder
>
> Follows the same approach as BMPImageDecoder: Use a
> FastSharedBufferReader to avoid consolidation.
>
> Add an optional offset to PNGImageDecoder for ICOImageDecoder, so that
> PNGImageDecoder can read a PNG subimage in an ICO without copying the
> data. This eliminates another call to SharedBuffer::data(), as well as
> a copy to create the separate SharedBuffer for PNG.
>
> BUG=467772
> BUG=528625
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201981
TBR=pkasting@chromium.org,noel@chromium.org,scroggo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=467772
Committed: https://crrev.com/05865c1b34b6c653b893b6f8bce7b86ddafadc4d
git-svn-id: svn://svn.chromium.org/blink/trunk@202198 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Patch Set 1 #
Messages
Total messages: 10 (2 generated)
|