Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
133823003:
Make all the files mapped in when running net_unittests read only. (Closed)
|
Created:
6 years, 11 months ago by M-A Ruel Modified:
6 years, 10 months ago Reviewers:
Vadim Sh. CC:
chromium-reviews, cbentzel+watch_chromium.org, Nico, csharp Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionMake all the files mapped in when running net_unittests read only.
This means no file can be opened for write during the test run.
R=vadimsh@chromium.org
BUG=116251
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249500
Patch Set 1 #Patch Set 2 : chunks #Patch Set 3 : rebase #Messages
Total messages: 19 (0 generated)
I'll wait for http://src.chromium.org/viewvc/chrome?view=rev&revision=244947 to stick on the CI before committing this one. I also resent try jobs on the jobs that had failed, but on android it was known to failed and required the last swarming_client DEPS roll, which is now in LKGR.
lgtm, if net_unittests manage to run in that mode...
On 2014/01/15 19:04:05, Vadim Sh. wrote: > lgtm, if net_unittests manage to run in that mode... It was tested that this passes locally on all 3 platforms when both https://codereview.chromium.org/141273010 and https://codereview.chromium.org/132183007 are applied.
The CQ bit was checked by maruel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/133823003/190001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...
The CQ bit was checked by maruel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/133823003/190001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...
The CQ bit was checked by maruel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/133823003/190001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...
On 2014/02/06 21:14:45, I haz the power (commit-bot) wrote: > Retried try job too often on android_aosp for step(s) compile > http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao... android_aosp is currently broken so using NOTRY=true.
The CQ bit was checked by maruel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/133823003/190001
Message was sent while issue was closed.
Change committed as 249500 |
