Modify CopyFileUnsafe() on OSX to stop copying ACL.

Modify CopyFileUnsafe() on OSX to stop copying ACL.

This makes CopyFile() and CopyDirectory() behavior consistent on OSX to the
other platforms. Stop copying the ACL on the files copied. This means the
destination file will inherit from the umask or inherited ACL from the
destination parent directory, which is sane.

This matches what is done on linux. This will fixes unit tests that copy files
from a read only directory into a temporary directory so they can be safely be
modified, otherwise the file acl would have to be modified everytime. While
base_unittests didn't care, it blew up disk cache tests in net_unittests.

R=thakis@chromium.org
BUG=116251, 335420
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249258

[Nico, 2014-01-17 21:39:41]

lgtm, xplat consistency of base functions is cool

+Mark to shout if this breaks invariants the installer code expects

[Mark Mentovai, 2014-01-17 21:41:22]

LGTM. I don’t know what does use CopyFileUnsafe, but I know that the installer
doesn’t.

[M-A Ruel, 2014-01-20 15:03:22]

Nico, did you archive the thread of https://codereview.chromium.org/141273010 by
accident? A *full weekend* without review. That's not normal. :P

[M-A Ruel, 2014-01-20 15:03:23]

Nico, did you archive the thread of https://codereview.chromium.org/141273010 by
accident? A *full weekend* without review. That's not normal. :P

[Nico, 2014-01-21 04:04:33]

On Mon, Jan 20, 2014 at 7:03 AM, <maruel@chromium.org> wrote:

> Nico, did you archive the thread of https://codereview.chromium.
> org/141273010 by
> accident? A *full weekend* without review. That's not normal. :P
>

If I don't reply to something within a day, I've usually forgotten about
it. Ping me if that happens.


>
> https://codereview.chromium.org/132183007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[M-A Ruel, 2014-02-05 22:17:09]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2014-02-05 22:20:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/132183007/120001

[commit-bot: I haz the power, 2014-02-06 03:42:42]

Change committed as 249258