Issue 1338003004: Merge to XFA: Fix strings, ..., void return types for Consts.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1338003004: Merge to XFA: Fix strings, ..., void return types for Consts.h. (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix strings, ..., void return types for Consts.h. (cherry picked from commit f9e40aec10263f9445d69598657f42550294d653) Orignal Review URL: https://codereview.chromium.org/1342433002 . R=thestig@chromium.org TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/142165e2f62b8ba727e8aab40591ca3a7b6fa214

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+384 lines, -351 lines)			Patch
M	fpdfsdk/include/javascript/Consts.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Define.h	View	6 chunks	+94 lines, -133 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Runtime.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	2 chunks	+34 lines, -26 lines	0 comments	Download
M	fpdfsdk/src/javascript/Consts.cpp	View	5 chunks	+68 lines, -57 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	2 chunks	+28 lines, -52 lines	0 comments	Download
M	fpdfsdk/src/javascript/global.cpp	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	8 chunks	+45 lines, -69 lines	0 comments	Download
M	testing/resources/javascript/consts.in	View	3 chunks	+58 lines, -3 lines	0 comments	Download
M	testing/resources/javascript/consts_expected.txt	View	1 chunk	+46 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

5 years, 3 months ago (2015-09-11 20:21:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
142165e2f62b8ba727e8aab40591ca3a7b6fa214 (presubmit successful).