Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1342433002: Fix strings, remove stringify macros, void return types for Consts.h (Closed)

Created:
5 years, 3 months ago by Tom Sepez
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix strings, remove stringify macros, void return types for Consts.h. Replace multiple #defines of the same strings with externs. Fix strings mangled by interaction of # and clang-format. Remove macros as possible. Make more JS_ functions void and simplify. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/f9e40aec10263f9445d69598657f42550294d653

Patch Set 1 #

Patch Set 2 : Added tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+384 lines, -351 lines) Patch
M fpdfsdk/include/javascript/Consts.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Define.h View 6 chunks +94 lines, -133 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/jsapi/fxjs_v8.h View 2 chunks +34 lines, -26 lines 0 comments Download
M fpdfsdk/src/javascript/Consts.cpp View 5 chunks +68 lines, -57 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 2 chunks +28 lines, -52 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 8 chunks +45 lines, -69 lines 0 comments Download
M testing/resources/javascript/consts.in View 1 3 chunks +58 lines, -3 lines 0 comments Download
M testing/resources/javascript/consts_expected.txt View 1 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Lei, for review. Fixes a few things that bugged me.
5 years, 3 months ago (2015-09-11 18:31:25 UTC) #1
Tom Sepez
On 2015/09/11 18:31:25, Tom Sepez wrote: > Lei, for review. Fixes a few things that ...
5 years, 3 months ago (2015-09-11 18:40:34 UTC) #2
Tom Sepez
Ok, time for review, Lei.
5 years, 3 months ago (2015-09-11 19:04:21 UTC) #4
Lei Zhang
lgtm
5 years, 3 months ago (2015-09-11 20:04:32 UTC) #5
Tom Sepez
5 years, 3 months ago (2015-09-11 20:04:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f9e40aec10263f9445d69598657f42550294d653 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698