skia: Add ANGLE with GL backend to nanobench/DM

skia: Add ANGLE with GL backend to nanobench/DM

This will allow us to test this without hacking it in, might be useful
for others too.

Committed: https://skia.googlesource.com/skia/+/eddbefb4a5794b1d9f4e58a7cdf4e768b837c17f

[hendrikw, 2015-09-11 18:40:07]

hendrikw@chromium.org changed reviewers:
+ bsalomon@google.com

[hendrikw, 2015-09-11 18:40:08]

PTAL

I didn't add it to SampleApp, do you think it would be useful there?

[bsalomon, 2015-09-11 18:54:47]

lgtm. Does it make sense to enable building ANGLE on non-windows platforms? (I'm
assuming setting skia_angle=1 in GYP_DEFINES doesn't work currently for anything
but windows).

https://codereview.chromium.org/1338003002/diff/20001/tools/PictureRenderer.h
File tools/PictureRenderer.h (right):

https://codereview.chromium.org/1338003002/diff/20001/tools/PictureRenderer.h...
tools/PictureRenderer.h:47: kAngle_GL_DeviceType,
The PictureRenderer stuff isn't really used anymore. Feel free to just not
modify this.

[hendrikw, 2015-09-11 20:01:17]

On 2015/09/11 18:54:47, bsalomon wrote:
> lgtm. Does it make sense to enable building ANGLE on non-windows platforms?
(I'm
> assuming setting skia_angle=1 in GYP_DEFINES doesn't work currently for
anything
> but windows).

I've pinged cwallez@, I'll see if ANGLE on linux could be useful for them.

> 
> https://codereview.chromium.org/1338003002/diff/20001/tools/PictureRenderer.h
> File tools/PictureRenderer.h (right):
> 
>
https://codereview.chromium.org/1338003002/diff/20001/tools/PictureRenderer.h...
> tools/PictureRenderer.h:47: kAngle_GL_DeviceType,
> The PictureRenderer stuff isn't really used anymore. Feel free to just not
> modify this.

Ok cool, removed these changes!

[hendrikw, 2015-09-11 20:01:19]

The CQ bit was checked by hendrikw@chromium.org

[hendrikw, 2015-09-11 20:01:20]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1338003002/#ps40001
(title: "remove PictureRenderer changes")

[commit-bot: I haz the power, 2015-09-11 20:01:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1338003002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1338003002/40001

[commit-bot: I haz the power, 2015-09-11 20:07:35]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/eddbefb4a5794b1d9f4e58a7cdf4e768b837c17f