chrome/chrome_browser.gypi - Issue 1337903002: permissions: remove PermissionQueueController and introduce PermissionInfoBarManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1337903002: permissions: remove PermissionQueueController and introduce PermissionInfoBarManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@callbacks-delegates

Patch Set: Rewrite to allowing infobar queuing and non-prompting of allowed/denied permisisons Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index c71d727f44e6dd78086f0b47782835fee0525720..01f8cc41132d1e424205f003d98dc261b6f1bc0e 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -2078,12 +2078,14 @@

'browser/permissions/permission_context_uma_util.h',

'browser/permissions/permission_infobar_delegate.cc',

'browser/permissions/permission_infobar_delegate.h',

+ 'browser/permissions/permission_infobar_request.cc',

+ 'browser/permissions/permission_infobar_request.h',

mlamouri (slow - plz ping) 2015/09/16 16:21:01 Should we make those Andorid specific?

Lalit Maganti 2015/09/16 17:28:38 As previous.

'browser/permissions/permission_manager.cc',

'browser/permissions/permission_manager.h',

'browser/permissions/permission_manager_factory.cc',

'browser/permissions/permission_manager_factory.h',

- 'browser/permissions/permission_queue_controller.cc',

- 'browser/permissions/permission_queue_controller.h',

+ 'browser/permissions/permission_infobar_manager.cc',

+ 'browser/permissions/permission_infobar_manager.h',

mlamouri (slow - plz ping) 2015/09/16 16:21:01 ditto

Lalit Maganti 2015/09/16 17:28:38 As previous.

'browser/permissions/permission_request_id.cc',

'browser/permissions/permission_request_id.h',

'browser/permissions/permission_update_infobar_delegate_android.cc',

« chrome/browser/ui/tab_helpers.cc ('K') | « chrome/browser/ui/tab_helpers.cc ('k') | no next file » | no next file with comments »