chrome/browser/ui/tab_helpers.cc - Issue 1337903002: permissions: remove PermissionQueueController and introduce PermissionInfoBarManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 1337903002: permissions: remove PermissionQueueController and introduce PermissionInfoBarManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@callbacks-delegates

Patch Set: Rewrite to allowing infobar queuing and non-prompting of allowed/denied permisisons Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_infobar_request.cc ('K') | « chrome/browser/permissions/permission_queue_controller_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | chrome/chrome_browser.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_helpers.cc

diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc

index 5f477c0dc193476a09ec612b226bb6f4a0527569..03c16d850f5afa66c8a905a3f910d2553a492d68 100644

--- a/chrome/browser/ui/tab_helpers.cc

+++ b/chrome/browser/ui/tab_helpers.cc

@@ -18,6 +18,7 @@

#include "chrome/browser/net/net_error_tab_helper.h"

#include "chrome/browser/net/predictor_tab_helper.h"

#include "chrome/browser/password_manager/chrome_password_manager_client.h"

+#include "chrome/browser/permissions/permission_infobar_manager.h"

#include "chrome/browser/predictors/resource_prefetch_predictor_factory.h"

#include "chrome/browser/predictors/resource_prefetch_predictor_tab_helper.h"

#include "chrome/browser/prerender/prerender_tab_helper.h"

@@ -163,6 +164,7 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

ManagePasswordsUIController::CreateForWebContents(web_contents);

NavigationCorrectionTabObserver::CreateForWebContents(web_contents);

NavigationMetricsRecorder::CreateForWebContents(web_contents);

+ PermissionInfoBarManager::CreateForWebContents(web_contents);

mlamouri (slow - plz ping) 2015/09/16 16:21:01 Should that be OS_ANDROID specific?

Lalit Maganti 2015/09/16 17:28:38 Maybe - see previous comment.

PopupBlockerTabHelper::CreateForWebContents(web_contents);

PrefsTabHelper::CreateForWebContents(web_contents);

prerender::PrerenderTabHelper::CreateForWebContents(web_contents);