Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: util/win/xp_compat.h

Issue 1337653005: win: Fix use of THREAD_ALL_ACCESS on XP (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: more checks Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/win/scoped_process_suspend_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/xp_compat.h
diff --git a/util/win/xp_compat.h b/util/win/xp_compat.h
index 1501f3c58e31bdaacbc61e97809399f46a27c796..7c62e41bed5994ff213adc60b55b9493ef28690f 100644
--- a/util/win/xp_compat.h
+++ b/util/win/xp_compat.h
@@ -25,7 +25,14 @@ enum {
//! Requesting `PROCESS_ALL_ACCESS` with the value defined when building
//! against a Vista+ SDK results in `ERROR_ACCESS_DENIED` when running on XP.
//! See https://msdn.microsoft.com/en-ca/library/windows/desktop/ms684880.aspx
- kXPProcessAllAccess = STANDARD_RIGHTS_REQUIRED | SYNCHRONIZE | 0xFFF
+ kXPProcessAllAccess = STANDARD_RIGHTS_REQUIRED | SYNCHRONIZE | 0xFFF,
+
+ //! \brief This is the XP-suitable value of `THREAD_ALL_ACCESS`.
+ //!
+ //! Requesting `THREAD_ALL_ACCESS` with the value defined when building
+ //! against a Vista+ SDK results in `ERROR_ACCESS_DENIED` when running on XP.
+ //! See https://msdn.microsoft.com/en-us/library/windows/desktop/ms686769.aspx
+ kXPThreadAllAccess = STANDARD_RIGHTS_REQUIRED | SYNCHRONIZE | 0x3FF,
};
} // namespace crashpad
« no previous file with comments | « util/win/scoped_process_suspend_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698