Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: util/win/xp_compat.h

Issue 1337653005: win: Fix use of THREAD_ALL_ACCESS on XP (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: more checks Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/win/scoped_process_suspend_test.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved. 1 // Copyright 2015 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #ifndef CRASHPAD_UTIL_WIN_XP_COMPAT_H_ 15 #ifndef CRASHPAD_UTIL_WIN_XP_COMPAT_H_
16 #define CRASHPAD_UTIL_WIN_XP_COMPAT_H_ 16 #define CRASHPAD_UTIL_WIN_XP_COMPAT_H_
17 17
18 #include <windows.h> 18 #include <windows.h>
19 19
20 namespace crashpad { 20 namespace crashpad {
21 21
22 enum { 22 enum {
23 //! \brief This is the XP-suitable value of `PROCESS_ALL_ACCESS`. 23 //! \brief This is the XP-suitable value of `PROCESS_ALL_ACCESS`.
24 //! 24 //!
25 //! Requesting `PROCESS_ALL_ACCESS` with the value defined when building 25 //! Requesting `PROCESS_ALL_ACCESS` with the value defined when building
26 //! against a Vista+ SDK results in `ERROR_ACCESS_DENIED` when running on XP. 26 //! against a Vista+ SDK results in `ERROR_ACCESS_DENIED` when running on XP.
27 //! See https://msdn.microsoft.com/en-ca/library/windows/desktop/ms684880.aspx 27 //! See https://msdn.microsoft.com/en-ca/library/windows/desktop/ms684880.aspx
28 kXPProcessAllAccess = STANDARD_RIGHTS_REQUIRED | SYNCHRONIZE | 0xFFF 28 kXPProcessAllAccess = STANDARD_RIGHTS_REQUIRED | SYNCHRONIZE | 0xFFF,
29
30 //! \brief This is the XP-suitable value of `THREAD_ALL_ACCESS`.
31 //!
32 //! Requesting `THREAD_ALL_ACCESS` with the value defined when building
33 //! against a Vista+ SDK results in `ERROR_ACCESS_DENIED` when running on XP.
34 //! See https://msdn.microsoft.com/en-us/library/windows/desktop/ms686769.aspx
35 kXPThreadAllAccess = STANDARD_RIGHTS_REQUIRED | SYNCHRONIZE | 0x3FF,
29 }; 36 };
30 37
31 } // namespace crashpad 38 } // namespace crashpad
32 39
33 #endif // CRASHPAD_UTIL_WIN_XP_COMPAT_H_ 40 #endif // CRASHPAD_UTIL_WIN_XP_COMPAT_H_
OLDNEW
« no previous file with comments | « util/win/scoped_process_suspend_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698