win: Fix use of THREAD_ALL_ACCESS on XP

util/win/xp_compat.h

Index: util/win/xp_compat.h
diff --git a/util/win/xp_compat.h b/util/win/xp_compat.h
index 1501f3c58e31bdaacbc61e97809399f46a27c796..7c62e41bed5994ff213adc60b55b9493ef28690f 100644
--- a/util/win/xp_compat.h
+++ b/util/win/xp_compat.h
@@ -25,7 +25,14 @@ enum {
   //! Requesting `PROCESS_ALL_ACCESS` with the value defined when building
   //! against a Vista+ SDK results in `ERROR_ACCESS_DENIED` when running on XP.
   //! See https://msdn.microsoft.com/en-ca/library/windows/desktop/ms684880.aspx
-  kXPProcessAllAccess = STANDARD_RIGHTS_REQUIRED | SYNCHRONIZE | 0xFFF
+  kXPProcessAllAccess = STANDARD_RIGHTS_REQUIRED | SYNCHRONIZE | 0xFFF,
+
+  //! \brief This is the XP-suitable value of `THREAD_ALL_ACCESS`.
+  //!
+  //! Requesting `THREAD_ALL_ACCESS` with the value defined when building
+  //! against a Vista+ SDK results in `ERROR_ACCESS_DENIED` when running on XP.
+  //! See https://msdn.microsoft.com/en-us/library/windows/desktop/ms686769.aspx
+  kXPThreadAllAccess = STANDARD_RIGHTS_REQUIRED | SYNCHRONIZE | 0x3FF,

[scottmg, 2015/09/11 22:51:01]

I could have left this in the test .cc, but it seemed odd to have one here and
not the other (it may yet be needed in the snapshot code too, currently failing
on XP for reasons unclear).

[Mark Mentovai, 2015/09/11 23:03:33]

scottmg wrote:
Yeah, I agree that she belongs here with her sister.

In this case, kXPThreadAllAccess misses THREAD_RESUME. Is that OK? Like the one
above, I assume it is because that’s implied by THREAD_SUSPEND_RESUME.

[scottmg, 2015/09/11 23:32:52]

Yes, I think so.

 };
 
 }  // namespace crashpad