win: Fix use of THREAD_ALL_ACCESS on XP

util/win/scoped_process_suspend_test.cc

Index: util/win/scoped_process_suspend_test.cc
diff --git a/util/win/scoped_process_suspend_test.cc b/util/win/scoped_process_suspend_test.cc
index 98f06433b0910a37b0fa3f01bfdf52d18d002a71..8841f90ccb3ce7eb0862a898353abf4177a92202 100644
--- a/util/win/scoped_process_suspend_test.cc
+++ b/util/win/scoped_process_suspend_test.cc
@@ -21,6 +21,7 @@
 
 #include "gtest/gtest.h"
 #include "test/win/win_child_process.h"
+#include "util/win/xp_compat.h"
 
 namespace crashpad {
 namespace test {
@@ -45,7 +46,8 @@ bool SuspendCountMatches(HANDLE process, DWORD desired_suspend_count) {
                          sizeof(te.th32OwnerProcessID) &&
         te.th32OwnerProcessID == process_id) {
       ScopedKernelHANDLE thread(
-          OpenThread(THREAD_ALL_ACCESS, false, te.th32ThreadID));
+          OpenThread(kXPThreadAllAccess, false, te.th32ThreadID));
+      EXPECT_TRUE(thread.is_valid());

[Mark Mentovai, 2015/09/11 23:03:33]

ASSERT_TRUE()? Otherwise everything that follows is suspect too.

All of these things that are ASSERTing or EXPECTing on a win32 call can stream
ErrorMessage from test/errors.h:
  ASSERT_TRUE(thread.is_valid()) << ErrorMessage("OpenThread");

[scottmg, 2015/09/11 23:32:52]

Yeah, I just hate ASSERT because there's no "return false;" version. Am I using
it wrong?

Added ErrorMessage()s.

[Mark Mentovai, 2015/09/11 23:36:28]

scottmg wrote:
No, that’s right, forgot this was a bool-returning function.

       DWORD result = SuspendThread(thread.get());
       EXPECT_NE(result, static_cast<DWORD>(-1));
       if (result != static_cast<DWORD>(-1))