Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1337643002: Made combo boxes into leaf nodes in all platform-specific accessibility trees. (Closed)

Created:
5 years, 3 months ago by nektarios
Modified:
5 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made combo boxes into leaf nodes in all platform-specific accessibility trees. BUG=530370 R=dmazzoni@chromium.org Committed: https://crrev.com/9cc0f861c7c212964a9020df9109a1156b911de4 Cr-Commit-Position: refs/heads/master@{#348803}

Patch Set 1 #

Patch Set 2 : Fixed test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/browser/accessibility/browser_accessibility.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-autocomplete-expected-win.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
nektarios
5 years, 3 months ago (2015-09-10 23:24:52 UTC) #1
dmazzoni
lgtm
5 years, 3 months ago (2015-09-10 23:25:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337643002/1
5 years, 3 months ago (2015-09-10 23:37:51 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/102570)
5 years, 3 months ago (2015-09-11 00:15:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337643002/20001
5 years, 3 months ago (2015-09-14 23:54:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-15 01:23:32 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9cc0f861c7c212964a9020df9109a1156b911de4 Cr-Commit-Position: refs/heads/master@{#348803}
5 years, 3 months ago (2015-09-15 01:24:06 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:40:53 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9cc0f861c7c212964a9020df9109a1156b911de4
Cr-Commit-Position: refs/heads/master@{#348803}

Powered by Google App Engine
This is Rietveld 408576698