content/browser/accessibility/browser_accessibility.cc - Issue 1337643002: Made combo boxes into leaf nodes in all platform-specific accessibility trees.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility.cc

Issue 1337643002: Made combo boxes into leaf nodes in all platform-specific accessibility trees. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test expectations. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/accessibility/browser_accessibility.cc

diff --git a/content/browser/accessibility/browser_accessibility.cc b/content/browser/accessibility/browser_accessibility.cc

index 940199be31631b2ea1760d62ab953af7d6e82b6c..93d84137ecd51970348f9b5e8e9f2419ea449035 100644

--- a/content/browser/accessibility/browser_accessibility.cc

+++ b/content/browser/accessibility/browser_accessibility.cc

@@ -50,6 +50,7 @@ bool BrowserAccessibility::PlatformIsLeaf() const {

// implementation details, but we want to expose them as leaves

// to platform accessibility APIs.

switch (GetRole()) {

+ case ui::AX_ROLE_COMBO_BOX:

case ui::AX_ROLE_LINE_BREAK:

case ui::AX_ROLE_SLIDER:

case ui::AX_ROLE_STATIC_TEXT:

« no previous file with comments | « no previous file | content/test/data/accessibility/aria/aria-autocomplete-expected-win.txt » ('j') | no next file with comments »