Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: src/gpu/SkGpuDevice.cpp

Issue 133763006: Remove redundant auto rt object in skpaint2grpaintshader function. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/SkGpuDevice.cpp
diff --git a/src/gpu/SkGpuDevice.cpp b/src/gpu/SkGpuDevice.cpp
index 86c8ba90f8a24c18f14eb20dc03256f341d50aeb..1e78a70680f2b5d829ff1bfbc0fe9f3e4e503dc5 100644
--- a/src/gpu/SkGpuDevice.cpp
+++ b/src/gpu/SkGpuDevice.cpp
@@ -505,10 +505,9 @@ inline bool skPaint2GrPaintShader(SkGpuDevice* dev,
return skPaint2GrPaintNoShader(dev, skPaint, false, constantColor, grPaint);
}
- // SkShader::asNewEffect() may do offscreen rendering. Setup default drawing state
- // Also require shader to set the render target .
+ // SkShader::asNewEffect() may do offscreen rendering. Setup default drawing state and require
+ // the shader to set a render target .
GrContext::AutoWideOpenIdentityDraw awo(dev->context(), NULL);
bsalomon 2014/01/13 14:47:10 this NULL param to awo() is the rt, so the art bel
- GrContext::AutoRenderTarget(dev->context(), NULL);
// setup the shader as the first color effect on the paint
SkAutoTUnref<GrEffectRef> effect(shader->asNewEffect(dev->context(), skPaint));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698