Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13375017: Move the ViewType enum to extensions\common. (Closed)

Created:
7 years, 8 months ago by jam
Modified:
7 years, 8 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Avi (use Gerrit), jennb, creis+watch_chromium.org, yoshiki+watch_chromium.org, jianli, jeremya+watch_chromium.org, kkania, Dmitry Titov, sail+watch_chromium.org, Aaron Boodman, robertshield, dcheng, tfarina, ajwong+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Move the ViewType enum to extensions\common. BUG=162530 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191650

Patch Set 1 #

Total comments: 14

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -377 lines) Patch
M chrome/browser/android/tab_android.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_util.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 1 5 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/event_router.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.h View 1 5 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 16 chunks +28 lines, -30 lines 0 comments Download
M chrome/browser/extensions/extension_host_mac.h View 1 1 chunk +2 lines, -2 lines 2 comments Download
M chrome/browser/extensions/extension_host_mac.mm View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 1 18 chunks +32 lines, -30 lines 0 comments Download
M chrome/browser/extensions/extension_webkit_preferences.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_webkit_preferences.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/lazy_background_task_queue.cc View 1 4 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/message_handler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/memory_details.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/notifications/balloon_host.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/browser_tab_contents.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_view_mac.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_view_gtk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel_host.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_view_views.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/view_type_utils.h View 1 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/browser/view_type_utils.cc View 1 1 chunk +0 lines, -45 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_messages.h View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/common/view_type.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/common/view_type.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 1 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/event_bindings.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/extension_custom_bindings.cc View 1 2 chunks +20 lines, -20 lines 0 comments Download
M chrome/renderer/extensions/extension_helper.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 1 10 chunks +12 lines, -13 lines 0 comments Download
A + extensions/browser/view_type_utils.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + extensions/browser/view_type_utils.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
A + extensions/common/view_type.h View 3 chunks +8 lines, -6 lines 0 comments Download
A + extensions/common/view_type.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jam
7 years, 8 months ago (2013-04-01 16:33:30 UTC) #1
Yoyo Zhou
LGTM with nits - a lot of the files are already in the extensions namespace, ...
7 years, 8 months ago (2013-04-01 17:36:51 UTC) #2
Yoyo Zhou
Also, you can use the more specific BUG=162530.
7 years, 8 months ago (2013-04-01 17:37:09 UTC) #3
jam
nits done I also ended up moving view_type_utils.* to extensions\browser in this cl. Almost all ...
7 years, 8 months ago (2013-04-01 17:55:11 UTC) #4
Yoyo Zhou
LGTM https://codereview.chromium.org/13375017/diff/9005/chrome/browser/extensions/extension_host_mac.h File chrome/browser/extensions/extension_host_mac.h (right): https://codereview.chromium.org/13375017/diff/9005/chrome/browser/extensions/extension_host_mac.h#newcode19 chrome/browser/extensions/extension_host_mac.h:19: const GURL& url, ViewType host_type) : 1 argument ...
7 years, 8 months ago (2013-04-01 20:22:57 UTC) #5
jam
7 years, 8 months ago (2013-04-01 20:23:51 UTC) #6 
https://codereview.chromium.org/13375017/diff/9005/chrome/browser/extensions/...
File chrome/browser/extensions/extension_host_mac.h (right):

https://codereview.chromium.org/13375017/diff/9005/chrome/browser/extensions/...
chrome/browser/extensions/extension_host_mac.h:19: const GURL& url, ViewType
host_type) :
On 2013/04/01 20:22:57, Yoyo Zhou wrote:
> 1 argument per line.

Done.

Powered by Google App Engine
This is Rietveld 408576698