Move the ViewType enum to extensions\common.

chrome/renderer/extensions/extension_custom_bindings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/extension_custom_bindings.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/string_util.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/url_constants.h"
-#include "chrome/common/view_type.h"
 #include "chrome/renderer/extensions/dispatcher.h"
 #include "chrome/renderer/extensions/extension_helper.h"
 #include "content/public/renderer/render_view.h"
 #include "content/public/renderer/v8_value_converter.h"
+#include "extensions/common/view_type.h"
 #include "grit/renderer_resources.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
 #include "webkit/glue/webkit_glue.h"
 #include "v8/include/v8.h"
 
 namespace extensions {
 
 namespace {
 
@@ skipping 15 matching lines @@
 
   if (!args[0]->IsInt32() || !args[1]->IsString())
     return v8::Undefined();
 
   // |browser_window_id| == extension_misc::kUnknownWindowId means getting
   // views attached to any browser window.
   int browser_window_id = args[0]->Int32Value();
 
   std::string view_type_string = *v8::String::Utf8Value(args[1]->ToString());
   StringToUpperASCII(&view_type_string);
-  // |view_type| == chrome::VIEW_TYPE_INVALID means getting any type of
+  // |view_type| == extensions::VIEW_TYPE_INVALID means getting any type of

[Yoyo Zhou, 2013/04/01 17:36:51]

''

   // views.
-  chrome::ViewType view_type = chrome::VIEW_TYPE_INVALID;
-  if (view_type_string == chrome::kViewTypeBackgroundPage) {
-    view_type = chrome::VIEW_TYPE_EXTENSION_BACKGROUND_PAGE;
-  } else if (view_type_string == chrome::kViewTypeInfobar) {
-    view_type = chrome::VIEW_TYPE_EXTENSION_INFOBAR;
-  } else if (view_type_string == chrome::kViewTypeNotification) {
-    view_type = chrome::VIEW_TYPE_NOTIFICATION;
-  } else if (view_type_string == chrome::kViewTypeTabContents) {
-    view_type = chrome::VIEW_TYPE_TAB_CONTENTS;
-  } else if (view_type_string == chrome::kViewTypePopup) {
-    view_type = chrome::VIEW_TYPE_EXTENSION_POPUP;
-  } else if (view_type_string == chrome::kViewTypeExtensionDialog) {
-    view_type = chrome::VIEW_TYPE_EXTENSION_DIALOG;
-  } else if (view_type_string == chrome::kViewTypeAppShell) {
-    view_type = chrome::VIEW_TYPE_APP_SHELL;
-  } else if (view_type_string == chrome::kViewTypePanel) {
-    view_type = chrome::VIEW_TYPE_PANEL;
-  } else if (view_type_string != chrome::kViewTypeAll) {
+  extensions::ViewType view_type = extensions::VIEW_TYPE_INVALID;
+  if (view_type_string == extensions::kViewTypeBackgroundPage) {
+    view_type = extensions::VIEW_TYPE_EXTENSION_BACKGROUND_PAGE;
+  } else if (view_type_string == extensions::kViewTypeInfobar) {
+    view_type = extensions::VIEW_TYPE_EXTENSION_INFOBAR;
+  } else if (view_type_string == extensions::kViewTypeNotification) {
+    view_type = extensions::VIEW_TYPE_NOTIFICATION;
+  } else if (view_type_string == extensions::kViewTypeTabContents) {
+    view_type = extensions::VIEW_TYPE_TAB_CONTENTS;
+  } else if (view_type_string == extensions::kViewTypePopup) {
+    view_type = extensions::VIEW_TYPE_EXTENSION_POPUP;
+  } else if (view_type_string == extensions::kViewTypeExtensionDialog) {
+    view_type = extensions::VIEW_TYPE_EXTENSION_DIALOG;
+  } else if (view_type_string == extensions::kViewTypeAppShell) {
+    view_type = extensions::VIEW_TYPE_APP_SHELL;
+  } else if (view_type_string == extensions::kViewTypePanel) {
+    view_type = extensions::VIEW_TYPE_PANEL;
+  } else if (view_type_string != extensions::kViewTypeAll) {
     return v8::Undefined();
   }
 
   const Extension* extension = GetExtensionForRenderView();
   if (!extension)
     return v8::Undefined();
 
   std::vector<content::RenderView*> views = ExtensionHelper::GetExtensionViews(
       extension->id(), browser_window_id, view_type);
   v8::Local<v8::Array> v8_views = v8::Array::New();
   int v8_index = 0;
   for (size_t i = 0; i < views.size(); ++i) {
     v8::Local<v8::Context> context =
         views[i]->GetWebView()->mainFrame()->mainWorldScriptContext();
     if (!context.IsEmpty()) {
       v8::Local<v8::Value> window = context->Global();
       DCHECK(!window.IsEmpty());
       v8_views->Set(v8::Integer::New(v8_index++), window);
     }
   }
 
   return v8_views;
 }
 
 }  // namespace extensions