Issue 13375002: Revert issue 158379 (chrome.window.create height)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13375002: Revert issue 158379 (chrome.window.create height) (Closed)

Created:
7 years, 8 months ago by stevenjb

Modified:
7 years, 8 months ago

Reviewers:
jeremya, sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert issue 158379 This reverts crbug.com/158379 which changed the apps v1 window creation behavior from outer bounds to inner bounds. That change broke "expected" behavior for a class of extensions, and made the behavior inconsistent between Create and Get/Update. There was some internal discussion about what expected behavior should be, and we decided to revert the behavior. A test was added for consistency between Create and Window properties, and the documentation was clarified. BUG=173831 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192181

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -15 lines)			Patch
M	chrome/browser/extensions/window_open_apitest.cc	View	1 2 3 4	1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 2 3 4 5 6	1 chunk	+3 lines, -6 lines	0 comments	Download
M	chrome/common/extensions/api/windows.json	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/window_open/window_size/manifest.json	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/window_open/window_size/popup.html	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/window_open/window_size/test.html	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/test/data/extensions/api_test/window_open/window_size/test.js	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stevenjb

7 years, 8 months ago (2013-04-03 23:00:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #7 manually as r192181 (presubmit successful).

Expand Messages | Collapse Messages

Issue 13375002: Revert issue 158379 (chrome.window.create height) (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Update documentation #

Patch Set 4 : Rebase #

Patch Set 5 : Disable new test on OSX #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Messages